New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rockstor Translations #1643

Merged
merged 2 commits into from Mar 26, 2017

Conversation

Projects
None yet
2 participants
@MFlyer
Member

MFlyer commented Feb 6, 2017

Ref to #821
Hi @phillxnet @schakrava @priyaganti ,
we can merge this to have a starting point (had some tests).

Having translations over all Rockstor requires adding data apis to every *.rst file & define every language.json lib (en not required, Rockstor current default) :)

lang attr removed to avoid fixed en lang (jquery.i18n tests lang attr and use default lang only if that missing)

This requires jslib repo PR

Mirko

MFlyer added some commits Feb 6, 2017

#821 Base configuration, PR to update and let all contributors code o…
…ver it

Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
#821 fixing regression
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava Mar 26, 2017

Member

Nice start @MFlyer . Looking forward to translation contributions. I'll come up with the proper repo division strategy. We should definitely make it as easy as possible for potential contributors to add translations.

Member

schakrava commented Mar 26, 2017

Nice start @MFlyer . Looking forward to translation contributions. I'll come up with the proper repo division strategy. We should definitely make it as easy as possible for potential contributors to add translations.

@schakrava schakrava merged commit e67d1df into rockstor:master Mar 26, 2017

1 check failed

default Build finished.
Details

@MFlyer MFlyer deleted the MFlyer:issue#821_Initial_PR branch Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment