New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbd devices do not support S.M.A.R.T. #1705

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
3 participants
@KaiRo-at
Contributor

KaiRo-at commented May 2, 2017

We are using a fork of Rockstor for a system that uses nbd devices. While most of the support we have for that is specific to our system, the fact that nbd devices do not support S.M.A.R.T. is something that upstream Rockstor can support well, so here's a patch for that. :)

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 2, 2017

Member

Can one of the admins verify this patch?

Member

schakrava commented May 2, 2017

Can one of the admins verify this patch?

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 2, 2017

Member

Can one of the admins verify this patch?

Member

schakrava commented May 2, 2017

Can one of the admins verify this patch?

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet May 2, 2017

Member

@KaiRo-at Hello again, Looks good to me: given the caveat of our other ongoing discussion re by-id names in #1704. But no harm putting this in as is.

Thanks for contributing this, most welcome.

Member

phillxnet commented May 2, 2017

@KaiRo-at Hello again, Looks good to me: given the caveat of our other ongoing discussion re by-id names in #1704. But no harm putting this in as is.

Thanks for contributing this, most welcome.

@KaiRo-at

This comment has been minimized.

Show comment
Hide comment
@KaiRo-at

KaiRo-at May 12, 2017

Contributor

If anyone has a "normal" nbd device, this is still useful, I guess. Of course, if we end up having nice "by-id" names with our solution to #1704, we may need another patch here, but then I guess that may not be something to upstream, depending on how it's done.

Contributor

KaiRo-at commented May 12, 2017

If anyone has a "normal" nbd device, this is still useful, I guess. Of course, if we end up having nice "by-id" names with our solution to #1704, we may need another patch here, but then I guess that may not be something to upstream, depending on how it's done.

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 18, 2017

Member

yay! upstream contribution from a fork. We feel special :)

Thank you @KaiRo-at

Member

schakrava commented May 18, 2017

yay! upstream contribution from a fork. We feel special :)

Thank you @KaiRo-at

@schakrava schakrava merged commit badf373 into rockstor:master May 18, 2017

@KaiRo-at KaiRo-at deleted the KaiRo-at:no-smart-for-nbd branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment