New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'for' attributes on user_create_template labels #1706

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
4 participants
@KaiRo-at
Contributor

KaiRo-at commented May 2, 2017

I stumbled over the s in user_create_template having a typo and missing for="" attributes, so I created a patch to fix this. ;-)

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 2, 2017

Member

Can one of the admins verify this patch?

Member

schakrava commented May 2, 2017

Can one of the admins verify this patch?

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 2, 2017

Member

Can one of the admins verify this patch?

Member

schakrava commented May 2, 2017

Can one of the admins verify this patch?

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet May 2, 2017

Member

@KaiRo-at Cool and thanks.
@MFlyer Does this look OK to you?

Member

phillxnet commented May 2, 2017

@KaiRo-at Cool and thanks.
@MFlyer Does this look OK to you?

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer May 2, 2017

Member

Good to me @phillxnet , not tested, but it seems ok!
Mirko

Member

MFlyer commented May 2, 2017

Good to me @phillxnet , not tested, but it seems ok!
Mirko

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer May 4, 2017

Member

To @schakrava : this can be merged too

Mirko

Member

MFlyer commented May 4, 2017

To @schakrava : this can be merged too

Mirko

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 18, 2017

Member

Thank you @phillxnet and @MFlyer for your reviews. I apologize for the annoying/repeated message from the buildbot :)

Thanks for your contribution @KaiRo-at

Member

schakrava commented May 18, 2017

Thank you @phillxnet and @MFlyer for your reviews. I apologize for the annoying/repeated message from the buildbot :)

Thanks for your contribution @KaiRo-at

@schakrava schakrava merged commit ac9a09c into rockstor:master May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment