New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create SHA256 certs so browser devtools don't complain all the time #1707

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
4 participants
@KaiRo-at
Contributor

KaiRo-at commented May 2, 2017

When developing things with Rocktor UI, I noticed a lot of warning about SHA1 certs in my browser's developer tools. Here's a patch that moves to SHA256, which does away with those warnings.

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 2, 2017

Member

Can one of the admins verify this patch?

Member

schakrava commented May 2, 2017

Can one of the admins verify this patch?

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 2, 2017

Member

Can one of the admins verify this patch?

Member

schakrava commented May 2, 2017

Can one of the admins verify this patch?

@phillxnet

This comment has been minimized.

Show comment
Hide comment
@phillxnet

phillxnet May 2, 2017

Member

@KaiRo-at Thanks again for another nice patch. Looks good to me.
However I'm afraid it's not really in my area so will have to pass this over to @MFlyer again as he is much more knowledgeable in this area.

Member

phillxnet commented May 2, 2017

@KaiRo-at Thanks again for another nice patch. Looks good to me.
However I'm afraid it's not really in my area so will have to pass this over to @MFlyer again as he is much more knowledgeable in this area.

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer May 2, 2017

Member

@phillxnet / @schakrava : hope to check this & be back coding be this week end! (new job -> new env -> new "headaches" understanding a new django project structure! eheh)

Edit to @KaiRo-at: are you sure about that?? Although moving to sha256, we still have a self-signed cert so my suspicion about Chrome/Chromium & FF still with warnings. Did you have any test?
🎉 Welcome on board 🎉

Edit to @KaiRo-at part 2: I'm used to check contributors (coders/testers/etc) profiles and try to understand -not "investigating"- because I think we're not numbers/accounts/bytes, but humans (yep, your blog!), so hope you'll enjoy and you'll stay! :)

Thanks
Mirko

Member

MFlyer commented May 2, 2017

@phillxnet / @schakrava : hope to check this & be back coding be this week end! (new job -> new env -> new "headaches" understanding a new django project structure! eheh)

Edit to @KaiRo-at: are you sure about that?? Although moving to sha256, we still have a self-signed cert so my suspicion about Chrome/Chromium & FF still with warnings. Did you have any test?
🎉 Welcome on board 🎉

Edit to @KaiRo-at part 2: I'm used to check contributors (coders/testers/etc) profiles and try to understand -not "investigating"- because I think we're not numbers/accounts/bytes, but humans (yep, your blog!), so hope you'll enjoy and you'll stay! :)

Thanks
Mirko

@MFlyer

This comment has been minimized.

Show comment
Hide comment
@MFlyer

MFlyer May 4, 2017

Member

To @schakrava & @phillxnet : tested, can be safely merged
Note: obviously this doesn't solve self-signed cert issue

Thanks ot @KaiRo-at :)

Mirko

Member

MFlyer commented May 4, 2017

To @schakrava & @phillxnet : tested, can be safely merged
Note: obviously this doesn't solve self-signed cert issue

Thanks ot @KaiRo-at :)

Mirko

@KaiRo-at

This comment has been minimized.

Show comment
Hide comment
@KaiRo-at

KaiRo-at May 12, 2017

Contributor

Yes, it doesn't solve the self-signed cert issue (on initial connection), but browser (at least Firefox) developer tools complain at every request (including the API ones) if a SHA1 cert is used, no matter is self-signed or not, and no matter if an exception exists. And that is annoying when doing development work and trying to find real messages in the Web Console. That's why I looked into this in the first place. ;-)

Contributor

KaiRo-at commented May 12, 2017

Yes, it doesn't solve the self-signed cert issue (on initial connection), but browser (at least Firefox) developer tools complain at every request (including the API ones) if a SHA1 cert is used, no matter is self-signed or not, and no matter if an exception exists. And that is annoying when doing development work and trying to find real messages in the Web Console. That's why I looked into this in the first place. ;-)

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 18, 2017

Member

agreed @KaiRo-at . Thanks for your contribution!

Member

schakrava commented May 18, 2017

agreed @KaiRo-at . Thanks for your contribution!

@schakrava schakrava merged commit 1d10559 into rockstor:master May 18, 2017

@schakrava

This comment has been minimized.

Show comment
Hide comment
@schakrava

schakrava May 18, 2017

Member

Welcome to our contributors club! I apologize for delaying my review, but glad to have merged.

Member

schakrava commented May 18, 2017

Welcome to our contributors club! I apologize for delaying my review, but glad to have merged.

apetersson pushed a commit to MineboxOS/rockstor-core that referenced this pull request Nov 10, 2017

apetersson pushed a commit to MineboxOS/rockstor-core that referenced this pull request Nov 10, 2017

@KaiRo-at KaiRo-at deleted the KaiRo-at:create-sha256-certs branch Nov 13, 2017

KaiRo-at added a commit to KaiRo-at/rockstor-core that referenced this pull request Nov 14, 2017

KaiRo-at added a commit to KaiRo-at/rockstor-core that referenced this pull request Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment