Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version and date incorrectly reported re update info. Fixes #1870 #1871

Conversation

phillxnet
Copy link
Member

A recent move to yum from rpm inadvertently caused a miss reporting of installed version for that of available version. This was due to the differing outputs and the inclusion of both installed and available in the newer yum format. The command switch set was revised to output only the installed version and to include the previously missing and required build date/time info. Consequent parsing adjustments were made to accommodate for the now changed date format.

Time info was excluded as it is not used.

@schakrava Ready for review.

Fixes #1870

Please see issue text for stable package test / validation procedure.

As there are currently existing anomalies in package change log dates and contents re recently added minor version numbers this must be resolved in future package releases for the intended function of the "List of changes in this update" to correctly populate. See issue text for details. Currently it will be blank for the more recent stable package releases but should work as intended when the date anomalies are resolved in future package releases (ie when package changelogs indicate the time of release).

Also tested by applying to a fresh 3.9.1-0 install pre and post testing channel subscription and thereafter then updating via command line to 3.9.1-15. In all instances installed and available were displayed correctly. An update from 3.9.1-15 to 3.9.1-16 was then successfully completed via the command line.

A recent move to yum from rpm inadvertently caused a miss
reporting of installed version for that of available version.
This was due to the differing outputs and the inclusion of
both installed and available in the newer yum format.
The command switch set was revised to output only the installed
version and to include the previously missing and required build
date/time info. Consequent parsing adjustments were made to
accommodate for the now changed date format.
Time info was excluded as it is not used.
@schakrava
Copy link
Member

Thanks @phillxnet

@schakrava schakrava merged commit ff6c2c9 into rockstor:master Dec 13, 2017
@phillxnet phillxnet deleted the 1870_version_and_date_incorrectly_reported_re_update_info branch December 13, 2017 10:54
@phillxnet
Copy link
Member Author

@schakrava Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version and date incorrectly reported re update info
2 participants