-
Notifications
You must be signed in to change notification settings - Fork 367
Update 01-presentation.md #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated a few conventions per feedback from serge.
|
Are we sure that "Open Source" should be replaced by "open-source"? I can see making it lower case, but it is being used as a title more than an adjective. ie. "open source software" is treated as one complete noun, rather than adjective + noun. Otherwise it looks all good. |
|
@EzequielBruni Thank you, I'm still getting the hang of the usage of "Open Source". I agree the title can be treated as a noun. Can I change that (and how would I do that) or do you do it? |
|
@Grammaresque You can just change it in your local copy of the repo/branch and push the code again or I can do it. Up to you. |
|
@EzequielBruni ok let me figure it out. I'm trying to learn everything at once, so practice helps. As long as I don't break anything. |
SergeCroise
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@EzequielBruni This is the last doc I edited before getting virtual editor installed, so I do not have a local copy of my edits. as far as I understand, once I do a PR I can no longer modify it here. So could you approve it, and I'll do another modification after that? I have a couple other changes to make as well, because I also missed the comments from the previous commit. thank you. |
|
@Grammaresque Looks like you'd like this to be merged and then you'd like to do another edit. There's another way this can be done too. You can use your GitHub interface and check out the branch "patch-3" and make additional changes there to this document. All of your current changes should be there. If you have questions, @EzequielBruni , @wsoyinka or I can answer them (I hope!)... I'll leave this PR open for now. Any changes you make to your repository "patch-3" will update this PR: https://github.com/Grammaresque/documentation/branches (see screenshot below) |
|  | ||
|
|
||
| ### Free / Open source | ||
| ### Free / Open-source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Free / Open-source | |
| ### Free / Open Source |
Test results for 29c2326:
|
sspencerwire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good! Thank you @Grammaresque!

Updated a few conventions per feedback from serge.
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)