Skip to content

Conversation

@Grammaresque
Copy link
Collaborator

@Grammaresque Grammaresque commented Dec 5, 2022

Updated a few conventions per feedback from serge.

Author checklist (Completed by original Author)

  • [ x] Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • [x ] If applicable, steps and instructions have been tested to work
  • [ x] Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

Updated a few conventions per feedback from serge.
@EzequielBruni
Copy link
Collaborator

Are we sure that "Open Source" should be replaced by "open-source"? I can see making it lower case, but it is being used as a title more than an adjective. ie. "open source software" is treated as one complete noun, rather than adjective + noun.

Otherwise it looks all good.

@Grammaresque
Copy link
Collaborator Author

@EzequielBruni Thank you, I'm still getting the hang of the usage of "Open Source". I agree the title can be treated as a noun. Can I change that (and how would I do that) or do you do it?

@EzequielBruni
Copy link
Collaborator

@Grammaresque You can just change it in your local copy of the repo/branch and push the code again or I can do it. Up to you.

@Grammaresque
Copy link
Collaborator Author

@EzequielBruni ok let me figure it out. I'm trying to learn everything at once, so practice helps. As long as I don't break anything.

SergeCroise
SergeCroise previously approved these changes Dec 5, 2022
Copy link
Contributor

@SergeCroise SergeCroise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Grammaresque
Copy link
Collaborator Author

@EzequielBruni This is the last doc I edited before getting virtual editor installed, so I do not have a local copy of my edits. as far as I understand, once I do a PR I can no longer modify it here. So could you approve it, and I'll do another modification after that? I have a couple other changes to make as well, because I also missed the comments from the previous commit. thank you.

@sspencerwire
Copy link
Contributor

sspencerwire commented Dec 6, 2022

@Grammaresque Looks like you'd like this to be merged and then you'd like to do another edit. There's another way this can be done too. You can use your GitHub interface and check out the branch "patch-3" and make additional changes there to this document. All of your current changes should be there. If you have questions, @EzequielBruni , @wsoyinka or I can answer them (I hope!)... I'll leave this PR open for now. Any changes you make to your repository "patch-3" will update this PR: https://github.com/Grammaresque/documentation/branches (see screenshot below)

@sspencerwire
Copy link
Contributor

your_patch-3_branch_checked_out

![Tux - The Linux mascot](images/tux.png)

### Free / Open source
### Free / Open-source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Free / Open-source
### Free / Open Source

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Test results for 29c2326:

Number of broken URLs: 0

URL,RESULT,FILENAME

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! Thank you @Grammaresque!

@sspencerwire sspencerwire merged commit cac8914 into rocky-linux:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants