New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to test files as I read the module. #6

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@lancew

lancew commented Dec 28, 2017

Ignore this if you don't like the formatting changes. :-)

lancew added some commits Dec 28, 2017

Minor tidy-up of test files.
Small changes as I was reading the test files.
@rocky

rocky requested changes Dec 28, 2017 edited

It is not about "Ignore this if you don't like the formatting changes", but whether anything substantive is done.

Running PerlTidy over some code isn't a thing. Anyone can do that.

But, sure I understand it might mean something to you or others.

So tell you what - to address both your and my concerns (which is about improving the unfinished code in end-user meaningful way), make some change that does that. Now that you have the code formatted in way that is pleasing to you, it should be easier to do.

Here are some suggestions, to improve the code:

We can piggy back these formatted changes on top of something more substantial. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment