Changes to be compatible with melpa #3

Merged
merged 3 commits into from Mar 27, 2013

Conversation

Projects
None yet
2 participants
@expez
Contributor

expez commented Mar 27, 2013

I'm not entirely happy with the summary in the header; you might want to edit this.

@rocky

This comment has been minimized.

Show comment Hide comment
@rocky

rocky Mar 27, 2013

What do you use for stripping blanks? Is there an emacs output-hook available?

rocky commented on f9245fe Mar 27, 2013

What do you use for stripping blanks? Is there an emacs output-hook available?

@expez

This comment has been minimized.

Show comment Hide comment
@expez

expez Mar 27, 2013

Contributor

Don't merge this just yet, the melpa recipe failed to build.

Contributor

expez commented Mar 27, 2013

Don't merge this just yet, the melpa recipe failed to build.

@rocky

This comment has been minimized.

Show comment Hide comment
@rocky

rocky Mar 27, 2013

Owner

On Wed, Mar 27, 2013 at 8:41 AM, Lars Andersen notifications@github.comwrote:

I'm not entirely happy with the summary in the header; you might want to
edit this.

Ok. If you can elaborate on what you are not happy with perhaps that will
help me address this.

My grammar and spelling are often a little weird (and I'm a native
speaker), but I suspect you mean something more than that, right?


You can merge this Pull Request by running

git pull https://github.com/expez/emacs-loc-changes package

Or view, comment on, or merge it at:

#3
Commit Summary

  • Delete trailing whitespace.
  • Add license, version, author and repo url.
  • Add sections for header, code, commentary and footer.

File Changes

  • M loc-changes.elhttps://github.com/rocky/emacs-loc-changes/pull/3/files#diff-0(50)

Patch Links:

Owner

rocky commented Mar 27, 2013

On Wed, Mar 27, 2013 at 8:41 AM, Lars Andersen notifications@github.comwrote:

I'm not entirely happy with the summary in the header; you might want to
edit this.

Ok. If you can elaborate on what you are not happy with perhaps that will
help me address this.

My grammar and spelling are often a little weird (and I'm a native
speaker), but I suspect you mean something more than that, right?


You can merge this Pull Request by running

git pull https://github.com/expez/emacs-loc-changes package

Or view, comment on, or merge it at:

#3
Commit Summary

  • Delete trailing whitespace.
  • Add license, version, author and repo url.
  • Add sections for header, code, commentary and footer.

File Changes

  • M loc-changes.elhttps://github.com/rocky/emacs-loc-changes/pull/3/files#diff-0(50)

Patch Links:

@expez

This comment has been minimized.

Show comment Hide comment
@expez

expez Mar 27, 2013

Contributor

cl (add-hook 'before-save-hook (lambda () (delete-trailing-whitespace))) is what I use to automagically remove whitespace. The commit makes it sound like I did something, but all I did was save the buffer :)

I also use have show-trailing-whitespace set to t when coding and I have whitespace-style set to '(face lines-tail) so text beyond the fill-column looks super ugly.

Contributor

expez commented Mar 27, 2013

cl (add-hook 'before-save-hook (lambda () (delete-trailing-whitespace))) is what I use to automagically remove whitespace. The commit makes it sound like I did something, but all I did was save the buffer :)

I also use have show-trailing-whitespace set to t when coding and I have whitespace-style set to '(face lines-tail) so text beyond the fill-column looks super ugly.

@expez

This comment has been minimized.

Show comment Hide comment
@expez

expez Mar 27, 2013

Contributor

Ok. If you can elaborate on what you are not happy with perhaps that will help me address this.

My grammar and spelling are often a little weird (and I'm a native speaker), but I suspect you mean something more than that, right?

I wrote the summary myself, it's not taken from anything of yours. Here it is:

;;; loc-changes.el --- Helps the user keep track of positions even after change.

I believe this short description shows up in the package manager as a short description of what the package does. If we make it sound good odds increases that people will check out the package.

Contributor

expez commented Mar 27, 2013

Ok. If you can elaborate on what you are not happy with perhaps that will help me address this.

My grammar and spelling are often a little weird (and I'm a native speaker), but I suspect you mean something more than that, right?

I wrote the summary myself, it's not taken from anything of yours. Here it is:

;;; loc-changes.el --- Helps the user keep track of positions even after change.

I believe this short description shows up in the package manager as a short description of what the package does. If we make it sound good odds increases that people will check out the package.

@expez

This comment has been minimized.

Show comment Hide comment
@expez

expez Mar 27, 2013

Contributor

haha, I was testing the recipe and was surprised when emacs wouldn't let me load it. But it won't let me load it because the package is built form this repo and the changes aren't merged in yet.

/facepalm

Unless you want to update the summary; go ahead and merge 👍

Contributor

expez commented Mar 27, 2013

haha, I was testing the recipe and was surprised when emacs wouldn't let me load it. But it won't let me load it because the package is built form this repo and the changes aren't merged in yet.

/facepalm

Unless you want to update the summary; go ahead and merge 👍

rocky added a commit that referenced this pull request Mar 27, 2013

Merge pull request #3 from expez/package
Changes to be compatible with melpa

@rocky rocky merged commit 9425cc2 into rocky:master Mar 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment