Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRC] Some minor changes #17

Merged
merged 5 commits into from May 3, 2018
Merged

[PRC] Some minor changes #17

merged 5 commits into from May 3, 2018

Conversation

@JJ
Copy link
Contributor

@JJ JJ commented May 3, 2018

Including a small MANIFEST error and moving test.pl to a better place. This module was assigned to me as part of the Pull Request Challenge.

JJ added 2 commits May 3, 2018
Updates MANIFEST, also closing #16
@rocky

This comment has been minimized.

Copy link

@rocky rocky commented on 9665313 May 3, 2018

test.pl should not be moved because it requires interactivity unless special there is special care.

It is a holdover from Term::ReadLine::Perl. https://metacpan.org/source/ILYAZ/Term-ReadLine-Perl-1.0303

@rocky
Copy link
Owner

@rocky rocky commented May 3, 2018

Thanks for going over this. The changes to README.pod I'll take if you isolate this separately. Thanks.

@JJ
Copy link
Contributor Author

@JJ JJ commented May 3, 2018

Changed back test.pl. If you need help with any other issue, please let me know.

@rocky rocky merged commit 94ebdbf into rocky:master May 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.