New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpan pr challenge #7

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@lharey

lharey commented Feb 16, 2015

Hi

I have been assigned this module as part of Neil Bowers 'CPAN pull request challenge'.

Haven't had time to do much. I noticed that the link to the 'Demo' moudle when reading the documentation on line did not work, so I have correct it.

Also moved the old test.pl program to t/test.t as per one of the exceptions on CPANTS (http://cpants.cpanauthors.org/dist/Term-ReadLine-Perl5).

Regards
Lisa

@rocky

This comment has been minimized.

Owner

rocky commented Feb 16, 2015

While I really really appreciate your helping and taking interest this little project, the change you propose I have trepidation on.

test.pl is there really from ILYAZ previousl module called Term::ReadlIne. He made a big fuss over the behavior and it has made me shy away from changing this. I have to think about whether I want to change this now. Probably, but let me mull it over.

As for the demo links, what I don't like about that is the hard-coded version in the link. I looked for a way to use a generic name, but I can't find one.

Could I interest you in making Term::ReadLine::Perl5::OO::Keymap more complete? Specifically what it could mostly use handling keymaps which bind to other keymaps, like ESC-ESC...

@lharey

This comment has been minimized.

lharey commented Feb 17, 2015

Hi

I appreciate your feedback and thankyou for responding so quickly to my
pull request.

I have no experience of GNU Readline/History library and the functionality
your modules provide. Most of my experience is in writing web applications.
But if you could give me a bit more information and point me in the right
direction for making the Term::ReadLine::Perl5::OO::Keymap more complete I
am happy to have give it a go when I get a chance.

Thanks
Lisa

On 16 February 2015 at 09:02, R. Bernstein notifications@github.com wrote:

While I really really appreciate your helping and taking interest this
little project, the change you propose have problems.

test.pl is there really from ILYAZ previousl module called
Term::ReadlIne. He made a big fuss over the behavior and it has made me shy
away from changing this. I have to think about whether I want to change
this now. Probably, but let me mull it over.

As for the demo links, what I don't like about that is the hard-coded
version in the link. I looked for a way to use a generic name, but I can't
find one.

Could I interest you in making Term::ReadLine::Perl5::OO::Keymap more
complete. Specifically what it could mostly use handling keymaps which bind
to other keymaps, like ESC-ESC...


Reply to this email directly or view it on GitHub
#7 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment