Handle missing player weights throwing errors #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 48 48
Lines 10582 10590 +8
=======================================
+ Hits 10579 10587 +8
Misses 3 3
Continue to review full report at Codecov.
|
If a player doesn't have a weight listed on his/her page, an AttributeError will be thrown while trying to call 'replace' on an object of None. Simply checking if the weight is valid prior to attempting to replace the unit will prevent this error. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
fix-nfl-invalid-player-weight
branch
from
a935517
to
985e61d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a player doesn't have a weight listed on his/her page, an
AttributeErrorwill be thrown while trying to callreplaceon an object ofNone. Simply checking if the weight is valid prior to attempting to replace the unit will prevent this error.Fixes #393
Signed-Off-By: Robert Clark robdclark@outlook.com