fix: builds on glibc >= 2.38 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any concrete chances that this PR will be merged? At the moment, I am using my own fork that includes @anmonteiro's patch (thanks!), but it's far from ideal. |
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Jan 6, 2025
CHANGES: ### Fixed - Fix cross-compilation by using the right `ar` binary (roddyyaga/pg_query-ocaml#15, @anmonteiro) - Fix build on glibc >= 2.38 (roddyyaga/pg_query-ocaml#17, @anmonteiro)
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Jan 18, 2025
CHANGES: ### Fixed - Fix cross-compilation by using the right `ar` binary (roddyyaga/pg_query-ocaml#15, @anmonteiro) - Fix build on glibc >= 2.38 (roddyyaga/pg_query-ocaml#17, @anmonteiro)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16
upgrading libpg_query is a bit too painful this time since they removed support for parsing
?param refs, which e.g. ppx_rapper depends on.This change simply ports pganalyze/libpg_query@9b21e32 over from upstream.