Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the default enable status of a check #484

Closed
rnelson0 opened this issue Jun 24, 2016 · 0 comments · Fixed by #495
Closed

Allow specifying the default enable status of a check #484

rnelson0 opened this issue Jun 24, 2016 · 0 comments · Fixed by #495
Labels

Comments

@rnelson0
Copy link
Collaborator

There are a number of new check requests being developed, some of which are not preferable to be enabled by default. Rather than forcing them out of puppet-lint and into an external gem, which forces someone to maintain the plugin and gem, improve the new_check function to include a enabled boolean.

Currently, there appears to be no way to configure this without editing configuration.rb and adding a line like self.settings['autoloader_layout_disabled'] = true. Direct editing of the defaults is not the preferred method to manage this.

binford2k added a commit to binford2k/puppet-lint that referenced this issue Jun 28, 2016
This commit adds back an 80chars check, but disables it by default. To
do this, I also added the ability to re-enable checks that have been
disabled.

The spec is failing and I don't have time to fix it just now, but it
works when called from the command line. I'll come back to it if nobody
else picks this up.

A better solution than calling `Puppet.configuration` to disable a check
like I did might be to extend the `new_check` method. That's not
orthagonal to this PR though.

Supercedes rodjek#488
Fixes rodjek#484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant