Add support for Ubuntu 14.04 LTS #32

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@blkperl

blkperl commented Mar 24, 2014

No description provided.

@jchonig

This comment has been minimized.

Show comment
Hide comment
@jchonig

jchonig Jun 10, 2014

I'm also having this issue and looked at the provided patch.

The fix of making a template out of logrotate.conf.erb looks good.

It might be more general to put tests in the os-specific classes (logrotate::defaults::debian for example) for OS versions that use the new version of logrotate.

Thoughts from rodjek?

Thanks.

Jeff

jchonig commented Jun 10, 2014

I'm also having this issue and looked at the provided patch.

The fix of making a template out of logrotate.conf.erb looks good.

It might be more general to put tests in the os-specific classes (logrotate::defaults::debian for example) for OS versions that use the new version of logrotate.

Thoughts from rodjek?

Thanks.

Jeff

wolfspyre pushed a commit to wolfspyre/puppet-logrotate that referenced this pull request Jul 9, 2014

@@ -5,6 +5,12 @@
# rotate log files weekly
weekly
+<% if @lsbmajdistrelease and (scope.function_versioncmp([@lsbmajdistrelease, '14']) >= 0) -%>

This comment has been minimized.

@rodjek

rodjek Sep 21, 2014

Owner

You should also check lsbdistid to ensure that this only applies to Ubuntu > 14.

@rodjek

rodjek Sep 21, 2014

Owner

You should also check lsbdistid to ensure that this only applies to Ubuntu > 14.

This comment has been minimized.

@blkperl

blkperl Jan 11, 2015

Why do I need to check both?

@blkperl

blkperl Jan 11, 2015

Why do I need to check both?

This comment has been minimized.

@blkperl

blkperl Feb 12, 2015

@rodjek Ping

This comment has been minimized.

@jchonig

jchonig Aug 24, 2015

You want to check both to insure that this change doesn't happen on distros other than Ubuntu. I.e. this would incorrectly be applied to Fedora releases > 14.

@jchonig

jchonig Aug 24, 2015

You want to check both to insure that this change doesn't happen on distros other than Ubuntu. I.e. this would incorrectly be applied to Fedora releases > 14.

@b4ldr b4ldr referenced this pull request Oct 21, 2014

Closed

Add su line to logrotate.conf #47

@luxflux

This comment has been minimized.

Show comment
Hide comment
@luxflux

luxflux Nov 22, 2014

Whats the state here?

luxflux commented Nov 22, 2014

Whats the state here?

@benjfield

This comment has been minimized.

Show comment
Hide comment
@benjfield

benjfield Jul 23, 2015

Looks good, I too have this issue and I am currently having to use this branch.

Looks good, I too have this issue and I am currently having to use this branch.

geoffdavis pushed a commit to UCSD-ANF/puppet-logrotate that referenced this pull request Feb 3, 2017

Merge pull request #32 from syseleven/fix_puppet_lint_issues
Fix puppet-lint issues and bad style
@blkperl

This comment has been minimized.

Show comment
Hide comment
@blkperl

blkperl Sep 15, 2017

Closing. I don't have time to address feedback

blkperl commented Sep 15, 2017

Closing. I don't have time to address feedback

@blkperl blkperl closed this Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment