Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Link teardown after suite incompatible with parallel_tests #526
cef3957 introduces an incompatibility with the parallel_tests gem (used/recommended by puppetlabs_spec_helper) as it removes the module symlink after every suite has completed.
When using parallel_tests, the suite is executed by multiple processes and the teardown executing at the end of each suite can cause the symlink to be removed while another process is running a test. This causes intermittent failures finding resources within the module under test (e.g. https://travis-ci.org/puppet-testing/puppetlabs-postgresql/jobs/240309046).
Could the teardown simply be reverted, leaving whatever symlink was created in place?
Whether it's a suite or individual example before/after, it'd still cause errors between multiple processes as they're modifying the same link.
If cleaning up the link's important then it'd perhaps be better to copy/recreate the whole fixtures directory in a temporary dir, but that may create a new class of issues.