Requires puppetlabs_spec_helper but doesn't add it as a dependency in the gemspec

[rtyler]

From this file

-> % rspec-puppet-init                                                                                                                                                                                                                                                          1 ↵
/home/tyler/.rvm/rubies/ruby-1.9.3-p0/lib64/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require': iconv will be deprecated in the future, use String#encode instead.
/home/tyler/.rvm/rubies/ruby-1.9.3-p0/lib64/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require': cannot load such file -- puppetlabs_spec_helper/puppetlabs_spec/puppet_internals (LoadError)
    from /home/tyler/.rvm/rubies/ruby-1.9.3-p0/lib64/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /home/tyler/.rvm/gems/ruby-1.9.3-p0@puppet-module-dev/gems/rspec-puppet-0.1.5/lib/rspec-puppet/example/function_example_group.rb:1:in `<top (required)>'
    from /home/tyler/.rvm/rubies/ruby-1.9.3-p0/lib64/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /home/tyler/.rvm/rubies/ruby-1.9.3-p0/lib64/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /home/tyler/.rvm/gems/ruby-1.9.3-p0@puppet-module-dev/gems/rspec-puppet-0.1.5/lib/rspec-puppet/example.rb:4:in `<top (required)>'
    from /home/tyler/.rvm/rubies/ruby-1.9.3-p0/lib64/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /home/tyler/.rvm/rubies/ruby-1.9.3-p0/lib64/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /home/tyler/.rvm/gems/ruby-1.9.3-p0@puppet-module-dev/gems/rspec-puppet-0.1.5/lib/rspec-puppet.rb:6:in `<top (required)>'
    from /home/tyler/.rvm/rubies/ruby-1.9.3-p0/lib64/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /home/tyler/.rvm/rubies/ruby-1.9.3-p0/lib64/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /home/tyler/.rvm/gems/ruby-1.9.3-p0@puppet-module-dev/gems/rspec-puppet-0.1.5/bin/rspec-puppet-init:5:in `<top (required)>'
    from /home/tyler/.rvm/gems/ruby-1.9.3-p0@puppet-module-dev/bin/rspec-puppet-init:19:in `load'
    from /home/tyler/.rvm/gems/ruby-1.9.3-p0@puppet-module-dev/bin/rspec-puppet-init:19:in `<main>'

[hunner]

It is listed in Gemfile for Bundler though.

[rtyler]

The Gemfile has no bearing on the actual generated .gem package that is published to rubygems.org however, the dependency needs to go into the .gemspec for that to work

[rtyler]

There's a problem adding the dependency to the gemspec it seems, the rspec-puppet gem and puppetlabs_spec_helper gem would then both name each other as dependencies causing a cyclic dependency error.

Gak.

[hunner]

Okay. I was just taking @rodjek's cue by not having all the dependencies in the Gemfile also in the rspec-puppet.gemspec file (like puppet).

As to the cycle dependencies, what would @branan say?

[rtyler]

I think there might be some confusion running around the Puppet community (and Puppet Labs!) on what a Gemfile should do versus what a gemspec file should do

[hunner]

It's more the fact that rspec-puppet and puppetlabs_spec_helper are conflationary and need some clean-up work such that they don't depend on each other.

[dLobatog]

Is this finally going to be on the gemspec?

[rharrison10]

I'm not quite clear on why puppetlabs_spec_helper requires rspec-puppet given its focus to be the integration point for external projects like rspec-puppet It seems that puppetlabs_spec_helper needs to be refactored to remove the dependency on rspec-puppet since you can't even require rspec-puppet without it. I can't for the life of me figure out which of the Redmine projects is the right one to file a bug against puppetlabs_spec_helper.

This is blocking packaging of both gems:
https://bugzilla.redhat.com/show_bug.cgi?id=787350

[rodjek]

Actually, I'm going to have to revert this as it causes a cyclic dependency loop because puppetlabs_spec_helper also requires rspec-puppet. I'm going to refactor out the bits that depend on puppetlabs_spec_helper so we don't remain in this situation.

[rharrison10]

I'm very grateful that you are taking action on this issue as it will allow packaging both gems as rpms. This issue has completely stopped my use of rspec-puppet and I feel like I'm falling quite far behind in my development of tests for my modules. Do you have any sort of guidance on how big of an effort this refactor is going to be?

I've opened an upstream bug against puppetlabs_spec_helper because I personally feel the refactor should actually happen on the Puppet Labs side. So once again thanks so much for taking the initiative to resolve the issue as I've gotten no response on the bug that I've filed with Puppet Labs. Please comment on / vote the bug up (or let me know if I've filed it in the wrong place) so it gets some attention.

[rodjek]

^^ has been merged into master and will be go out in the upcoming 0.2.0 release.