Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something in trusted_server_facts is failing Puppet 4.0.0 Gem #663

Closed
glennsarti opened this issue Mar 13, 2018 · 0 comments
Closed

Something in trusted_server_facts is failing Puppet 4.0.0 Gem #663

glennsarti opened this issue Mar 13, 2018 · 0 comments
Labels
Milestone

Comments

@glennsarti
Copy link

glennsarti commented Mar 13, 2018

The puppetlabs-puppet_agent module has recently started failing (in spectacular fashion) since rspec-puppet 2.6.10 was released. The Puppet Gem ~> 4.0.0 cell is now failing. Last known good run was using rspec-puppet 2.6.9

Failed run -https://travis-ci.org/puppetlabs/puppetlabs-puppet_agent/jobs/352629851
Last known good - https://travis-ci.org/puppetlabs/puppetlabs-puppet_agent/jobs/348013913

Note they're both using the same hash

Error seems to be related to;

1.1) �[31mFailure/Error:�[0m
          �[31m  �[0mraise �[1;34;4mArgumentError�[0m,�[0m
          �[31m    �[0m�[31m�[1;31m"�[0m�[31mAttempt to assign a value to unknown setting #{name.inspect}�[0m�[31m�[1;31m"�[0m�[31m�[0m�[0m
          �[31m�[0m
          �[31mArgumentError:�[0m
          �[31m  Attempt to assign a value to unknown setting :trusted_server_facts�[0m
          �[36m# ./vendor/bundle/ruby/2.1.0/gems/puppet-4.0.0/lib/puppet/settings.rb:1311:in `set'�[0m
          �[36m# ./vendor/bundle/ruby/2.1.0/gems/puppet-4.0.0/lib/puppet/settings.rb:333:in `block in initialize_app_defaults'�[0m
          �[36m# ./vendor/bundle/ruby/2.1.0/gems/puppet-4.0.0/lib/puppet/settings.rb:329:in `each'�[0m
          �[36m# ./vendor/bundle/ruby/2.1.0/gems/puppet-4.0.0/lib/puppet/settings.rb:329:in `initialize_app_defaults'�[0m
          �[36m# ./vendor/bundle/ruby/2.1.0/gems/rspec-puppet-2.6.11/lib/rspec-puppet/adapters.rb:52:in `setup_puppet'�[0m
          �[36m# ./vendor/bundle/ruby/2.1.0/gems/rspec-puppet-2.6.11/lib/rspec-puppet/adapters.rb:111:in `setup_puppet'�[0m
          �[36m# ./vendor/bundle/ruby/2.1.0/gems/rspec-puppet-2.6.11/lib/rspec-puppet.rb:114:in `block (2 levels) in <top (required)>'�[0m

Ignore the colour codes.

I've manually verified on a docker image that 2.6.9 works and 2.6.10 throws the same error.

Repro instructions

  • Clone the repro
  • Checkout master or 1.x branch (both heads are the same as of creation of this issue)
  • Use Ruby 2.1.x
  • Bundle install (note the rspec-puppet version)
  • run bundle exec rake spec
jfroche added a commit to kuleuven/puppet-firewalld that referenced this issue Apr 26, 2018
As `rspec-puppet` breaks with puppet 4.0.0 (see rodjek/rspec-puppet#663),
I propose to drop tests and support for puppet 4.0.0
jfroche added a commit to kuleuven/puppet-firewalld that referenced this issue Apr 26, 2018
As `rspec-puppet` breaks with puppet 4.0.0 (see rodjek/rspec-puppet#663),
I propose to drop tests and support for puppet 4.0.0
@rodjek rodjek added this to the 2.6.13 milestone Jun 19, 2018
@rodjek rodjek added the bug label Jun 19, 2018
rodjek added a commit to rodjek/puppetlabs-puppet_agent that referenced this issue Aug 1, 2018
The bug that necessitated the pinning (rodjek/rspec-puppet#663) has been
resolved and this module can return to tracking the latest versions of
rspec-puppet again.
donoghuc pushed a commit to donoghuc/puppetlabs-puppet_agent that referenced this issue Aug 2, 2018
The bug that necessitated the pinning (rodjek/rspec-puppet#663) has been
resolved and this module can return to tracking the latest versions of
rspec-puppet again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants