/rspec-puppet

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes expected error for missing dependency under Puppet 5 #485

Merged
merged 1 commit into from Mar 28, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.6.0
3 participants
@domcleal @coveralls @rodjek
@domcleal
Contributor

domcleal commented Mar 27, 2017

Since PUP-5659, the message for a missing require dependency has changed
as it's now validated during catalog compilation:

error during compilation: Could not find resource 'File[/tmp/missing]' in parameter 'require' at line 52 on node rspec::puppet::manifestmatchers::compile
@domcleal
Fixes expected error for missing dependency under Puppet 5 
Since PUP-5659, the message for a missing require dependency has changed
as it's now validated during catalog compilation:

    error during compilation: Could not find resource 'File[/tmp/missing]' in parameter 'require' at line 52 on node rspec::puppet::manifestmatchers::compile
Verified
This commit was signed with a verified signature.
@domcleal domcleal Dominic Cleal
GPG key ID: 7C7D326F2C2B72CC Learn about signing commits
Loading status checks…
c749120
@coveralls

This comment has been minimized.

Sign in to view

coveralls commented Mar 27, 2017

Coverage Status

Changes Unknown when pulling c749120 on domcleal:spec-dependency-puppet-5 into ** on rodjek:master**.

@rodjek rodjek merged commit eb0e46f into rodjek:master Mar 28, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rodjek rodjek added this to the 2.6.0 milestone Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment