Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password parameter for rig #22

Closed
sbervinov opened this issue May 30, 2018 · 9 comments
Closed

Add password parameter for rig #22

sbervinov opened this issue May 30, 2018 · 9 comments
Labels

Comments

@sbervinov
Copy link

@sbervinov sbervinov commented May 30, 2018

Hi. I cannot see password parameter for rig. W\o that your program is not usable for me. Can you add it?

I`m talking about rig configuration:

#RIG_ID, MINER, PRIMARY_POOL_LABEL, SECONDARY_POOL_LABEL, RIG_URL/IP, INSTALLED_GPUS/THREADS,TARGET_HASHRATE,TARGET_HASHRATE_2nd_COIN,PLUG_TYPE,PLUG_IP,MAX_POWER,MAX_TEMP

You have RIG_URL/IP, but you do not have RIG_PASSWORD

@rodneymo

This comment has been minimized.

Copy link
Owner

@rodneymo rodneymo commented May 31, 2018

Currently the claymore implementation uses the http remote mgmt, not the json-rpc, as the html output has more info than the json. How do you pass the password as part of the http request? I couldn't find info about it anywhere

@sbervinov

This comment has been minimized.

Copy link
Author

@sbervinov sbervinov commented May 31, 2018

I use Phoenix Miner, but it and Claymore work the same as I know.
In Phoenix Miner I use -cdmport -cdmpass. In Claymore I used -mport -mpsw. W\o password it is not secure. Sometime I can see in logs requests to restart miner, but because miner is protected by password, restart commands ignored.

Using HTTP request to IP:port I can see text logs only. For that I do not need password.

I also use remote manager of Claymore for Phoenix Miner. And in remote manager I use password.

That is all the information which I can provide to you.

@rodneymo

This comment has been minimized.

Copy link
Owner

@rodneymo rodneymo commented Jun 5, 2018

Using HTTP request to IP:port I can see text logs only. For that I do not need password.

That's fine for rig-monitor. Then why would I need to implement the password support if it can already read the stats without password?

@StefanOberhumer

This comment has been minimized.

Copy link

@StefanOberhumer StefanOberhumer commented Jun 6, 2018

Just as info if you need using the RPC API on Claymore:
The Claymore RPC API supports the parameter "psw" to pass a password - eg:
echo '{"id":0,"jsonrpc":"2.0","method":"miner_getstat1", "psw":"SECRET_PASSWORD" }' | netcat <RIG_IP> <PORT>

@rodneymo

This comment has been minimized.

Copy link
Owner

@rodneymo rodneymo commented Jun 8, 2018

Thanks @StefanOberhumer but the claymore implementation uses html as it provides better data granularity e.g. gnu shares
My understanding is that even if the password is set you can still query the stats via http w/o password, is that not the case?

@StefanOberhumer

This comment has been minimized.

Copy link

@StefanOberhumer StefanOberhumer commented Jun 8, 2018

I think you are right - even if the password is set you can still query the stats via http w/o password
So if you query claymore using http, you should not need any password (think I've tried claymore 11.6 with that)
As I did not know how you query PhoenicMiner/Claymore (RPC or http) - I just added my knowledge about RPC API and the password in Claymore.
As @sbervinov uses PhoenixMiner and it seems the miner supports RPC of Claymore (have not tested that) I think use of psw and parsing RPC API would be a solution
Maybe you join Claymore RPC API as it seems to be like a standard - even if the query result is in an awful format.
Btw: The html result of the http request in claymore also includes the info of the RPC API miner_getstat1 call!

@StefanOberhumer

This comment has been minimized.

Copy link

@StefanOberhumer StefanOberhumer commented Jun 8, 2018

... e.g. gnu shares

What are "gnu" shares ?

@rodneymo

This comment has been minimized.

Copy link
Owner

@rodneymo rodneymo commented Jun 9, 2018

gpu shares, nothing to do with animals or sw licensing ;-)

@rodneymo

This comment has been minimized.

Copy link
Owner

@rodneymo rodneymo commented Jun 9, 2018

Closing this issues as it seems it does not affect the html end point

@rodneymo rodneymo closed this Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.