Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for lib package #36

Merged
merged 1 commit into from Oct 12, 2019

Conversation

@faabiosr
Copy link
Contributor

faabiosr commented Oct 12, 2019

Tests was created to cover the usage of Cache lib.

Tests was created to cover the usage of Cache lib.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #36 into master will decrease coverage by 1.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   26.95%   25.22%   -1.73%     
==========================================
  Files           4        7       +3     
  Lines         141      226      +85     
==========================================
+ Hits           38       57      +19     
- Misses        103      169      +66
Impacted Files Coverage Δ
lib/cache.go 100% <0%> (ø)
lib/fetch.go 0% <0%> (ø)
lib/storage.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d402f...c075d7c. Read the comment docs.

@rodrigo-brito

This comment has been minimized.

Copy link
Owner

rodrigo-brito commented Oct 12, 2019

Hi @faabiosr, it looks great! Thank you for your contribution.
The coverage decrease because the package does not have any test. But it is not a problem.

@rodrigo-brito rodrigo-brito merged commit b31b417 into rodrigo-brito:master Oct 12, 2019
3 of 4 checks passed
3 of 4 checks passed
Build
Details
codecov/project 25.22% (-1.73%) compared to 29d402f
Details
codecov/patch Coverage not affected when comparing 29d402f...c075d7c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.