Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch user data with uuid /me route #24

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

luisgustavoo
Copy link
Contributor

When calling the /me route to fetch data from the logged in user, it is returning a 500 error, as the user has a uuid and not an int id.

image

@rodrigorahman
Copy link
Owner

@luisgustavoo Escrevi 2 testes para validar a implementação do me para aquando for int ou uuid.

O seu código não passa quando estamos trabalhando com uuid.

Atualiza sua branch para pegar os testes e coloca na sua alteração a verificação do tipo do idType:

    final idUser = switch(_config.idType) {
      IdTypeEnum.int => int.parse(id),
      IdTypeEnum.uuid => id,
    };

@luisgustavoo
Copy link
Contributor Author

Blz, vou atualizar aqui! Valeu

Copy link

gitguardian bot commented Mar 8, 2024

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
4262883 Triggered Generic High Entropy Secret 42dd5bb test/server/server_config/config.yaml View secret
4262883 Triggered Generic High Entropy Secret 75b7746 test/server/mock/auth_custom_fields_config.json View secret
4262883 Triggered Generic High Entropy Secret 75b7746 test/server/server_config/config.yaml View secret
4262883 Triggered Generic High Entropy Secret 75b7746 test/server/server_config/config_bk.yaml View secret
4262883 Triggered Generic High Entropy Secret 75b7746 test/server/server_config/config.yaml View secret
4262883 Triggered Generic High Entropy Secret 75b7746 test/server/mock/auth_default_config.json View secret
4262883 Triggered Generic High Entropy Secret 75b7746 test/server/mock/auth_default_id_int_config.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@rodrigorahman rodrigorahman merged commit 7b5ad11 into rodrigorahman:main Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants