Skip to content

Conversation

@omus
Copy link
Contributor

@omus omus commented Aug 15, 2018

It would be a good idea to enable nighties on Travis CI.

@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   76.55%   76.55%           
=======================================
  Files           8        8           
  Lines         418      418           
=======================================
  Hits          320      320           
  Misses         98       98
Impacted Files Coverage Δ
src/path.jl 87.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89cd2f1...5a4f3d0. Read the comment docs.

@ararslan
Copy link
Contributor

diff --git a/src/path.jl b/src/path.jl
index 2beecaa..7466ece 100644
--- a/src/path.jl
+++ b/src/path.jl
@@ -701,7 +701,7 @@ function Base.chmod(path::AbstractPath, symbolic_mode::AbstractString; recursive
     end
 end
 
-Base.read(path::AbstractPath) = open(readstring, String(path))
+Base.read(path::AbstractPath) = read(String(path), String)
 
 function Base.write(path::AbstractPath, content::AbstractString, mode="w")
     open(String(path), mode) do f

This should fix the CI failures on 1.0.

@ararslan ararslan mentioned this pull request Aug 16, 2018
@rofinn
Copy link
Owner

rofinn commented Aug 17, 2018

Oh the Pkg version check :(

@rofinn rofinn merged commit 63b3a4f into rofinn:master Aug 17, 2018
@omus omus deleted the cv/1.0-compat branch August 18, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants