fix(renderer): render multiple font sources #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why tests are failing in travis. They pass locally |
* Fix the renderFont method so that it correctly render the src key when multiple files are passed. * Add a test * Fix faulty tests in fela-plugin-embedded * Update all packages dependant on "fela" to the latest version * Update CHANGELOG
TxHawks
force-pushed
the
fix/fela-font-renderer
branch
from
47318dc
to
a84e2af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
generateFontSourceiterated over the list of files passed torenderer.renderFont,and reduced it to a single string. Instead of adding each resulting string to the previous string,
is has overwritten it.
A byproduct of overwriting was that if more than one file was passed, it resulted in an invalid string source, since it started with a
,.This pull request fixed the above bug and
generateFontSourcenow accumulates instead of overwrite.Versioning
Patch
fela
Checklist
Quality Assurance
yarn run format)yarn run lint)yarn run test)yarn run flow)Changes
If one of the following checks doesn't make sense due to the type of PR, just check them.