New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM1.9 Fix ? #1

Closed
P4R4DiSi4C opened this Issue Nov 5, 2016 · 14 comments

Comments

Projects
None yet
7 participants
@P4R4DiSi4C
Copy link

P4R4DiSi4C commented Nov 5, 2016

Hello !
I saw you didn't support SM 1.9.
Do you think to release a fix soon ?

Thank you so much

@rogeraabbccdd

This comment has been minimized.

Copy link
Owner

rogeraabbccdd commented Nov 5, 2016

I didn't test my plugin in SM1.9, this bug is reported by Nachtfrische in this post.

Btw, I'm using SM1.8.0-5947 in my server.

@VirtualHeaven

This comment has been minimized.

Copy link

VirtualHeaven commented Nov 14, 2016

I'm running on SM 1.9 without any problems, only one issue with the rankme db being reset after mapchange (using mysql), otherwise everything works just fine for me.

With sqlite db it works too, no resets after mapchange

@rogeraabbccdd

This comment has been minimized.

Copy link
Owner

rogeraabbccdd commented Nov 15, 2016

Thanks for your feedback, I'll checking mysql problem.

@rogeraabbccdd

This comment has been minimized.

Copy link
Owner

rogeraabbccdd commented Nov 15, 2016

@VirtualHeaven Do you have any error log?

@Nachtfrische

This comment has been minimized.

Copy link

Nachtfrische commented Nov 15, 2016

Hey,

as I've mentioned in the thread here, I'm having the same problem as VirtualHeaven. It works fine on 1.9 but the points are not saved after a mapchange. I'm using MySQL as well.

Error logs are:
L 11/02/2016 - 23:45:09: [SM] Exception reported: Instruction contained invalid parameter
L 11/02/2016 - 23:45:09: [SM] Blaming: rankme_kento.smx
L 11/02/2016 - 23:45:09: [SM] Call stack trace:
L 11/02/2016 - 23:45:09: [SM] [1] Line 1221, C:\Program Files (x86)\Steam\SteamApps\common\csgo plug\sourcemod-1.7.3-git5280-windows\addons\sourcemod\scripting\rankme_kento.sp::Event_RoundEnd

and

L 11/03/2016 - 23:53:14: [SM] Exception reported: Instruction contained invalid parameter
L 11/03/2016 - 23:53:14: [SM] Blaming: rankme_kento.smx
L 11/03/2016 - 23:53:14: [SM] Call stack trace:
L 11/03/2016 - 23:53:14: [SM] [1] Line 1221, rankme_kento.sp::Event_RoundEnd

The database is filled with players and the default points of 1000, but they are not updated because the points gather in the rounds stay are lost and reset back to 1000 after the map change.

I'll be willing to try and test any new test version under 1.9. Thanks.

@rogeraabbccdd

This comment has been minimized.

Copy link
Owner

rogeraabbccdd commented Nov 15, 2016

Confirmed, 3.0.3.Kento.3 is also not working in SM1.9.
In fact, I'm not planning to update this plugin for SM1.9 before it become stable.

@Nachtfrische

This comment has been minimized.

Copy link

Nachtfrische commented Nov 15, 2016

I know that SM1.9 is a dev build but is it really so much trouble to fix it now? You are going to have to fix it at some point, it shouldn't matter if you fix it now or if you fix it in 6 months.

@bcart22

This comment has been minimized.

Copy link

bcart22 commented Dec 1, 2016

Alot of people, including myself, had to switch to 1.9 because of the last CSGO update 11/28/16. I know it's not stable, but I would really appreciate a working patch for this. If you can do it, hope you take it into consideration. Thank you so much!

@rogeraabbccdd

This comment has been minimized.

Copy link
Owner

rogeraabbccdd commented Dec 1, 2016

Unfortunately, I'm still using SM1.8 after glove update. (1.8-5961)

@TR1D

This comment has been minimized.

Copy link
Contributor

TR1D commented Dec 1, 2016

All fixes are introduced in 1.8

@peace-maker

This comment has been minimized.

Copy link

peace-maker commented Dec 11, 2016

It's because of the ridiculously long Format call in SalvarPlayer with 37 arguments. You need to rethink your table layout or split the string up into multiple smaller Format calls to get it to run in SM1.9.
SM1.9 enforces calls to obey the maximal argument count of 32 arguments. There's a mismatch in the allowed argument count between the compiler and the VM which's fix is pending.

Just stopping by 😉

@rogeraabbccdd

This comment has been minimized.

Copy link
Owner

rogeraabbccdd commented Dec 11, 2016

What the...
I hope SM1.9 can fix this asap, I'm too lazy to rethink the tables.

@peace-maker

This comment has been minimized.

Copy link

peace-maker commented Dec 12, 2016

Well, it could be fixed by obeying the maximal argument count in all places in the compiler. You're only allowed to define functions with 32 arguments at max, but calls of vararg functions slipped through that check. Just split up the Format calls into multiple smaller ones. You can still construct the long query, but just not with one call.

@rogeraabbccdd

This comment has been minimized.

Copy link
Owner

rogeraabbccdd commented Jan 11, 2017

Fixed In 3.0.3.Kento.18 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment