+ Picky::Client::ActiveRecord#remove specs

client/lib/picky-client/client/active_record.rb

@@ -61,20 +61,18 @@ def initialize *attributes
             # updated the data do we want to index.
             #
             model.after_commit do |object|
+              data = { 'id' => object.id }
+
               if object.destroyed?
                 client.remove index_name, data
               else
-                data = { 'id' => object.id }
-
                 (attributes || object.attributes.keys).each do |attr|
                   data[attr] = object.respond_to?(attr) &&
                                object.send(attr) ||
                                object[attr]
                 end
 
-                # TODO Name #replace?
-                #
-                client.index index_name, data
+                client.replace index_name, data
               end
             end
 

client/spec/picky-client/client/active_record_spec.rb

@@ -75,11 +75,19 @@ def after_commit
       end
 
       it 'calls the right method in the client' do
-        client.should_receive(:index).once.with 'some_index_name', { 'id' => 1, 'name' => 'Niko', 'surname' => 'Dittmann' }
+        client.should_receive(:replace).once.with 'some_index_name', { 'id' => 1, 'name' => 'Niko', 'surname' => 'Dittmann' }
 
         ar.save
       end
+
+      it 'calls the right method in the client' do
+        client.should_receive(:remove).once.with 'some_index_name', { 'id' => 1 }
+
+        ar.destroy
+      end
+
     end
+
     context 'with client and index' do
       let(:ar_module) { described_class.new :client => client, :index => 'some_other_index_name' }
       let(:ar) { fake_ar.extend(ar_module).new(1, 'Niko', 'Dittmann') }
@@ -89,10 +97,16 @@ def after_commit
       end
 
       it 'calls the right method in the client' do
-        client.should_receive(:index).once.with 'some_other_index_name', { 'id' => 1, 'name' => 'Niko', 'surname' => 'Dittmann' }
+        client.should_receive(:replace).once.with 'some_other_index_name', { 'id' => 1, 'name' => 'Niko', 'surname' => 'Dittmann' }
 
         ar.save
       end
+
+      it 'calls the right method in the client' do
+        client.should_receive(:remove).once.with 'some_other_index_name', { 'id' => 1 }
+
+        ar.destroy
+      end
     end
     context 'with client and specific attributes' do
       let(:ar_module) { described_class.new 'name', :client => client }
@@ -103,10 +117,16 @@ def after_commit
       end
 
       it 'calls the right method in the client' do
-        client.should_receive(:index).once.with 'some_index_name', { 'id' => 1, 'name' => 'Niko' }
+        client.should_receive(:replace).once.with 'some_index_name', { 'id' => 1, 'name' => 'Niko' }
 
         ar.save
       end
+
+      it 'calls the right method in the client' do
+        client.should_receive(:remove).once.with 'some_index_name', { 'id' => 1 }
+
+        ar.destroy
+      end
     end
     context 'standard client' do
       it 'instantiates the client correctly' do
@@ -119,7 +139,6 @@ def after_commit
 
         described_class.new :host => 'some_host', :port => :some_port, :path => '/bla'
       end
-
     end
   end