New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boards.txt #238

Merged
merged 1 commit into from Jul 3, 2017

Conversation

Projects
None yet
4 participants
@Testato
Contributor

Testato commented Dec 17, 2016

PR for issue #200

  • replaced upload.flash.maximum_size and upload.ram.maximum_size by the new arduino standard upload.maximum_size and upload.maximum_data_size
  • corrected Flash and Ram value
  • Tested by builded every MCU on every Variant
Update boards.txt
PR for issue #200

- replaced `upload.flash.maximum_size` and `upload.ram.maximum_size` by the new arduino standard `upload.maximum_size` and `upload.maximum_data_size`
- corrected Flash and Ram value
- Tested by builded every MCU on every Variant
@rogerclarkmelbourne

This comment has been minimized.

Show comment
Hide comment
@Testato

This comment has been minimized.

Show comment
Hide comment
@Testato

Testato Jul 3, 2017

Contributor

link not working

Contributor

Testato commented Jul 3, 2017

link not working

@stevstrong

This comment has been minimized.

Show comment
Hide comment
@stevstrong
Contributor

stevstrong commented Jul 3, 2017

@rogerclarkmelbourne

This comment has been minimized.

Show comment
Hide comment
@rogerclarkmelbourne

rogerclarkmelbourne Jul 3, 2017

Owner

@stevstrong

Thanks. I was cutting and pasting many links, I think I got out of sync

Owner

rogerclarkmelbourne commented Jul 3, 2017

@stevstrong

Thanks. I was cutting and pasting many links, I think I got out of sync

@stevstrong

This comment has been minimized.

Show comment
Hide comment
@stevstrong

stevstrong Jul 3, 2017

Contributor

I see low risk (F4 related) and big benefit.

Contributor

stevstrong commented Jul 3, 2017

I see low risk (F4 related) and big benefit.

@victorpv

This comment has been minimized.

Show comment
Hide comment
@victorpv

victorpv Jul 3, 2017

Contributor

Looks good to me too. Seems like Arduino changed those labels, so it's good to change them, and some sizes were wrong and look better now.
Adding as a follow up on the forum thread. Our linker scripts currently do not allocate any RAM from the CCM block, so although a chip may have say 192KB total, the current maximum excludes CCM,
If we are not changing the linker scripts, may be best to leave that out. I raised the same issue in the forum, let's wait until everyone chimes in.

Contributor

victorpv commented Jul 3, 2017

Looks good to me too. Seems like Arduino changed those labels, so it's good to change them, and some sizes were wrong and look better now.
Adding as a follow up on the forum thread. Our linker scripts currently do not allocate any RAM from the CCM block, so although a chip may have say 192KB total, the current maximum excludes CCM,
If we are not changing the linker scripts, may be best to leave that out. I raised the same issue in the forum, let's wait until everyone chimes in.

@rogerclarkmelbourne rogerclarkmelbourne merged commit 8096bb6 into rogerclarkmelbourne:master Jul 3, 2017

@rogerclarkmelbourne

This comment has been minimized.

Show comment
Hide comment
@rogerclarkmelbourne
Owner

rogerclarkmelbourne commented Jul 3, 2017

Thanks

@victorpv

This comment has been minimized.

Show comment
Hide comment
@victorpv

victorpv Jul 3, 2017

Contributor

@Testato the current linker scripts do not allocate anything to the CCM memory, so the MCU can't use it.
Reporting 192KB of available RAM when the MCU in fact can only use 128KB would not be appropiate. Unless you are planning to modify the linker scripts, it would be better to report the memory in those MCU as the normal RAM capacity excluding CCM.
Could you correct and resubmit?

Contributor

victorpv commented Jul 3, 2017

@Testato the current linker scripts do not allocate anything to the CCM memory, so the MCU can't use it.
Reporting 192KB of available RAM when the MCU in fact can only use 128KB would not be appropiate. Unless you are planning to modify the linker scripts, it would be better to report the memory in those MCU as the normal RAM capacity excluding CCM.
Could you correct and resubmit?

@Testato

This comment has been minimized.

Show comment
Hide comment
@Testato

Testato Jul 4, 2017

Contributor

@victorpv
#303

@rogerclarkmelbourne
updated also the f407v to use the new arduino label, this board was not present at the time of my first PR

Contributor

Testato commented Jul 4, 2017

@victorpv
#303

@rogerclarkmelbourne
updated also the f407v to use the new arduino label, this board was not present at the time of my first PR

@victorpv

This comment has been minimized.

Show comment
Hide comment
@victorpv

victorpv Jul 4, 2017

Contributor

Thanks Tetato. I think it makes more sense like that until a decission is made on how to use CCM and we make it usable.
There is a thread in the forum discussing on that if you want to join.

Contributor

victorpv commented Jul 4, 2017

Thanks Tetato. I think it makes more sense like that until a decission is made on how to use CCM and we make it usable.
There is a thread in the forum discussing on that if you want to join.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment