Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native find support #2062

Open
lengstrom opened this issue Jul 10, 2014 · 23 comments
Open

Native find support #2062

lengstrom opened this issue Jul 10, 2014 · 23 comments
Assignees

Comments

@lengstrom
Copy link

Does NW support any sort of find system?

Example: In Google Chrome, when you press control - f, you get a find window that shows a series of highlighted words on the site that match your pattern. Does node-webkit have anything like this?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@skhavari
Copy link

something like this could be integrated in node-webkit or built into the client app.

https://github.com/padolsey/findAndReplaceDOMText

@nwjs-bot
Copy link

This should be working with latest version now.

In 0.13 we changed to an optimized architecture so more features can be supported, see http://nwjs.io/blog/whats-new-in-0.13/ and it's good for keeping up with Chromium upstream -- we released with Node.js v6.0 and new Chromium versions within 1 day after upstream release.

The new version would fixed many issues reported here and we're scrubbing them. This issue is closed as we believe it should be fixed. Please leave a message if it isn't and we'll reopen it.

@eriegz
Copy link

eriegz commented Sep 21, 2016

There's nothing in the above release 0.13 documentation that says anything about native find support being added. Was this feature actually added? If so, in which release? Where's the documentation?

@PriteshGajjar008
Copy link

Can someone confirm if this works? I tried but didn't work for me. I don't see any UI options on clicking Ctrl+F.

@PriteshGajjar008
Copy link

Its not working with latest version 0.21.3. Please advice.

@rogerwang rogerwang reopened this Mar 20, 2017
@PriteshGajjar008
Copy link

Any updates on this?

@PriteshGajjar008
Copy link

I see this is reopened. @Christywl Can you provide your view on this issue please?

@Christywl
Copy link
Contributor

Yes, I tried on nwjs-sdk-v0.21.3, it doesn't work. Users can't use CTRL-F to search for a word.

@PriteshGajjar008
Copy link

Okay. Let us know when you guys are planning to work on this.

@rogerwang
Copy link
Member

Thanks for your patience. We plan to fix it soon by providing an API and you can bind it to the hotkey. It shouldn't be a default behavior.

@peq42
Copy link

peq42 commented Dec 10, 2018

@rogerwang So, any news on this? Couldn't find on documentation/google

@franck34
Copy link

+1

@rogerwang
Copy link
Member

This is depending on #5875 , which has some progress recently. This feature should be easy to implement after that one is done.

@colorao
Copy link

colorao commented May 18, 2019

+1

1 similar comment
@truesolarflame
Copy link

+1

@TheJaredWilcurt
Copy link
Member

I created an easy to use tool as a temporary stand in.


find-in-nw


Usage

  1. npm install --save findinnw
  2. In your HTML file add:
    <script src="node_modules/findinnw/dist/find-in-nw.js"></script>
    <script>
      findInNw.initialize();
    </script>
  3. Use CTRL+F and ESC to show/hide the search box

API

@prominentdetail
Copy link

any update on this?

@rogerwang
Copy link
Member

I'll start adding browser features (including this) after #7230 is resolved.

@calumsult
Copy link

Is there an opportunity to fund this work?

@rogerwang
Copy link
Member

@calumsult you could put a bounty on this feature via BountySource or IssueHunt.

@gusazevedo
Copy link

So... nothing yet? (sad face)

@yushghimire
Copy link

any updates on this?

@DavidAccola
Copy link

Checking in on this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests