Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

special processing for corrupted local packages #8

Closed
gshep opened this issue Jun 1, 2020 · 0 comments · Fixed by #9
Closed

special processing for corrupted local packages #8

gshep opened this issue Jun 1, 2020 · 0 comments · Fixed by #9
Assignees
@gshep
Labels
enhancement New feature or request

Comments

@gshep
Copy link
Contributor

gshep commented Jun 1, 2020

If there are already some packages in local CNPM root and they are corrupted somehow (partially downloaded, wrong checksum, etc) then:

  1. remove the package(s) if it wasn't extracted correctly;
  2. show corresponding message. If the package(s) was downloaded during the current process then in addition show advise to check the package(s) on the server;
  3. stop CMake (fatal_error in previous step). User has to rerun CMake.
@gshep gshep added the enhancement New feature or request label Jun 1, 2020
@gshep gshep self-assigned this Jun 1, 2020
gshep added a commit to gshep/cnpm that referenced this issue Jun 1, 2020
@gshep
issue rogii-com#8
3f648a1 
remove package file if it couldn't extracted correctly (take archives
with wrong checksum into account too).
show additional text if the package was downloaded during the process.
@gshep gshep mentioned this issue Jun 1, 2020
Merged
chak3r added a commit that referenced this issue Jun 2, 2020
@chak3r
Merge pull request #9 from gshep/issue_8
b8e957f 
issue #8
@gshep gshep linked a pull request Jun 2, 2020 that will close this issue
issue #8 #9
Merged
@gshep gshep closed this as completed Jun 2, 2020
gshep added a commit to gshep/cnpm-tests that referenced this issue Jun 2, 2020
@gshep
issue rogii-com/cnpm#8
48585a7 
switch to cnpm v0.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gshep gshep

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue #8 gshep/cnpm
1 participant
@gshep