Skip to content

[FIX] improved projects page responsiveness. #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2022
Merged

[FIX] improved projects page responsiveness. #146

merged 2 commits into from
Sep 17, 2022

Conversation

Yazdun
Copy link
Contributor

@Yazdun Yazdun commented Sep 17, 2022

Changes proposed

I noticed that projects section is not properly responsive, the image was scaling weirdly on different screen sizes and also there were way too much white spaces on the sides which didn't look very good. I added grid to the projects wrapper so we can use the white spaces for showing more cards on larger screen size.

Screenshots

before changes :

before changes

after changes :

after changes

@vercel
Copy link

vercel bot commented Sep 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
projectmate ✅ Ready (Inspect) Visit Preview Sep 17, 2022 at 7:06AM (UTC)

Copy link
Owner

@rohitdasu rohitdasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution 👍

@RakeshSangem RakeshSangem changed the title Responsive [FIX] improved projects page responsiveness. Sep 17, 2022
Copy link
Contributor

@RakeshSangem RakeshSangem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing 🎉

@rohitdasu rohitdasu merged commit 5c8302f into rohitdasu:main Sep 17, 2022
@Yazdun Yazdun deleted the responsive branch September 17, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants