Don't attempt to create exception classes #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves #126 by not attempting to create exception classes. A couple of points no less: 1. The `ActiveRecord` specific exceptions _are_ loaded and merged when its railtie is loaded. Our tests do not load `ActiveRecord` so while they don't exist in our context, they _will_ be around in your garden variety rails application. 2. We essentially replicate what the `ExceptionWrapper` was doing for us, but by leveraging `Rack::Utils.status_code` we avoid the need to create an instance of the actual exception class. Thus avoiding the problems experienced creating exceptions that expect initializer arguments.
|
Looks, good. I was afraid that one needs to load 2/3 of rails for this. LGTM |
benlovell
added a commit
that referenced
this pull request
Jun 16, 2015
Don't attempt to create exception classes
|
<3 cutting a release. |
|
\o/! Thank you so much @benlovell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #126 by not attempting to create exception classes. A
couple of points no less:
ActiveRecordspecific exceptions are loaded and merged whenits railtie is loaded. Our tests do not load
ActiveRecordso whilethey don't exist in our context, they will be around in your garden
variety rails application.
ExceptionWrapperwas doing forus, but by leveraging
Rack::Utils.status_codewe avoid the need tocreate an instance of the actual exception class. Thus avoiding the
problems experienced creating exceptions that expect initializer
arguments.