Rails 3.2.x compatibility #8

Merged
merged 7 commits into from Feb 7, 2014

Projects

None yet

3 participants

@iancanderson
Collaborator

Changes:

  • Updated readme
  • ActionController::Session::AbstractStore is now ActionDispatch::Session::AbstractStore in rails 3
  • #set_session method is now passed the rack session options as a fourth parameter
  • Remove 'secret' option from docs - no longer part of rails session config (it's now a separate rails config options called secret_token)
  • set_session method now returns the session's id
    • Rails 3.2.x depends on rack ~1.4.5, which requires that the session store's #set_session method return the session_id upon successful saving
iancanderson added some commits Feb 6, 2014
@iancanderson iancanderson First stab at rails 3.2.x compatibility
- ActionController::Session::AbstractStore is now ActionDispatch::Session::AbstractStore in rails 3
- #set_session method is now passed the rack session options as a fourth parameter
c2f7a47
@iancanderson iancanderson Merge branch 'master' into rails-3.2-compatibility 82e73fe
@iancanderson iancanderson Update readme for rails 3.x configuration 000d620
@iancanderson iancanderson Remove 'secret' option from docs - no longer part of rails session co…
…nfig
d299ee7
@iancanderson iancanderson Update gemspec with renamed test file d93aa4a
@iancanderson iancanderson set_session method now returns the session's id
- Rails 3.2.x depends on rack ~1.4.5, which requires that the session store's #set_session method return the session_id upon successful saving
7d11ba3
@iancanderson iancanderson Add myself to authors file :) 078beec
@meatballhat
Collaborator

@roidrage considering the Rails team dropped support for Rails 2, are you OK with also dropping support for it? 😺 If so, I'll merge and take the blame!

@roidrage
Owner
roidrage commented Feb 7, 2014

Given that you can still use previous versions with it, I guess I'd be fine with that.

We'll see if someone complains, I guess? :)

@meatballhat
Collaborator

@roidrage I'm going to merge this, then submit a follow up PR for your review to bump the version, add some loud warnings about Rails compatibility, etc.

@meatballhat meatballhat merged commit 1f9f527 into roidrage:master Feb 7, 2014

1 check passed

default The Travis CI build passed
Details
@meatballhat meatballhat deleted the unknown repository branch Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment