New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopping uploading process #8

Closed
arriflex2 opened this Issue Apr 28, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@arriflex2

arriflex2 commented Apr 28, 2014

Hello and thank you again for your really great job!

I would like to suggest an option: could it be possible to
stop an uploading process? I did nont find any way (except logging out)
to stop the uploading prossec of a heavy file.

Thank you very much!

@roikku roikku added the enhancement label Apr 29, 2014

@roikku roikku added this to the release 1.0.4 milestone Apr 29, 2014

@roikku roikku self-assigned this Apr 29, 2014

@roikku

This comment has been minimized.

Owner

roikku commented Apr 29, 2014

Hi,

Thanks for your contribution. Currently, there is no means of gracefully stopping the process... (logging out or closing the app are the only ways).
I agree that such a function would be useful. I will take a look.

Cheers,
Loic

roikku added a commit that referenced this issue May 5, 2014

@roikku

This comment has been minimized.

Owner

roikku commented May 5, 2014

Partially solved this issue. The currently proposed implementation may not satisfy all the users' expectation.

Indeed, when stop is requested, the process will effectively stop only after the current operation is complete. For example, if the task is to upload a directory, and the user decides to stop the task while it is still in progress, the process will stop only after the completion of the upload of the file that is being uploaded when the stop request is made.

Such a behaviour is certainly acknowledged as totally acceptable as far as the file is rather small. Nevertheless, it might become questionable when the file is very large. For instance, if the file has a size of 5GB and the stop request is made just after starting uploading, then the user may become confused...

Let's say that there remain some room for improvement.

@arriflex2

This comment has been minimized.

arriflex2 commented May 6, 2014

Thank you very much for taking care of this suggestion!
It will be a usefull option although it still has limitations!

roikku added a commit that referenced this issue May 14, 2014

roikku added a commit that referenced this issue May 14, 2014

@roikku roikku closed this May 15, 2014

roikku added a commit that referenced this issue May 24, 2014

addressed issue #18 and issue #24, made some changes regarding issue #8
…, various improvements and minor bug corrections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment