Make generate_reflection save the fixture place automatically #181
Conversation
|
I've just sprinkled in some cfgs to get this passing, but we'll need to add the Windows toolchain / target in the workflow if we want this to actually be checked. |
It is UB for func to panic because it is called by the extern fn callback.
|
Are you guys sure this isn't a better solution than setting auto-recovery interval to a minute and waiting until an auto-save is put into a folder? You should be able to do that with Lua (to set the settings) and safe Rust (to track the auto-saves). |
|
This does work mechanically, but has a problem: Roblox Studio's autosaves are There are a couple other problems that are not addressed by this commit. First, the autosave directory will not necessarily be |
|
The autosave directory is a setting, I thought. |
|
It's a |
It's likely that the user is off in another window editing a place which will trigger an auto-save - very bad for us!
|
The scope of this work has increased somewhat, so this is the last change I'll make here before splitting off tomorrow into rbx_binary and roblox-install to get the rest done. roblox-install will need to read and write Studio settings. I still need to look at what exactly needs to be done to start using rbx_binary here. |
|
This is starting to look like something I'd be down to ship! |
Pending rbx_binary changes
This reverts commit f698ea7. (lol)
|
I've removed all the earlier junk and replaced it with a compiled AutoHotKey script. The resulting executable contains the AutoHotKey interpreter in addition to the script and will run on a machine without an AutoHotKey installation. Notably, this obviates the need for both #183 and #182. This only solves the problem on Windows but I'll take it! If we want to do the same for MacOS in the future, we can look at using AppleScript. |
I should really start running it automatically...
|
Seems we've pretty well exhausted the possible solutions. We cannot rely on Roblox Studio's auto-recovery feature because it outputs The right solution seems to be AutoHotKey Except It's a Rust Library. I am starting work on a minimal crate that will provide functionality similar to 0269d7d so we can finally finish up this feature. |
|
...and there we are. AutoHotkey does a very elaborate song and dance to handle the problem of modifiers being down during the send (and I have no doubt it's all necessary to properly do), so I chose to just ignore that for now. |
enigo has some problems (at least on Windows)1, and to get this to work more-or-less reliably we need to do things with the WinAPI that no crate I'm aware of currently does... so we'll do it live!
This PR adds the struct
StudioKeyboardthat can send keystrokes to Roblox Studio, or indeed any process' top-level visible window. It does so by attaching Roblox Studio's input processing mechanism to the current foreground thread's viaAttachThreadInputand sending keyboard events withSendInput. AutoHotKey also uses this technique.The failure cases feel kind of bad as an end user who is probably using cmd or powershell, but it definitely makes it easier for us to use this tool and makes it possible to run it on a CI machine.
1For example, it uses a
transmute_copythat invokes UB to create keyboard events. It also doesn't properly useSendInput- the entire point of this function is that it inserts multiple events serially into the input stream (which is why it takes an array), but enigo only passes one at a time!