Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
NO-ISSUE Use log.Errorf with format strings (openshift#545)
This was printing a log like:
`error running \"oc adm release extract\" for release %squay.io/...`
  • Loading branch information
carbonin committed Oct 14, 2020
1 parent 10f76a0 commit 684a8a2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/installercache/installercache.go
Expand Up @@ -79,7 +79,7 @@ func Get(releaseID, cacheDir, pullSecret string, log logrus.FieldLogger) (string
cmd.Stderr = &out
err = cmd.Run()
if err != nil {
log.Error("error running \"oc adm release extract\" for release %s", releaseID)
log.Errorf("error running \"oc adm release extract\" for release %s", releaseID)
log.Error(out.String())
return "", err
}
Expand Down

0 comments on commit 684a8a2

Please sign in to comment.