Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9.x support (8.0 release?) #121

Closed
wants to merge 2 commits into from
Closed

Laravel 9.x support (8.0 release?) #121

wants to merge 2 commits into from

Conversation

jonnott
Copy link

@jonnott jonnott commented Jan 13, 2022

Description of the change

Support illuminate/support 9.x, therefore being Laravel 9.x compatible (whilst still compatible with older Laravel versions too). Last update to 7.0 of this package only needed a similar change to composer.json, so just getting the ball rolling. I can't spot anything obviously different in illuminate/support 9.x which would break anything this package is using.. illuminate/support@8.x...9.x

Type of change

  • Maintenance
  • New release

Related issues

See comment here #120

@niektenhoopen
Copy link

@bishopb Any chance that you might be able to merge this? It's only a composer requirement change and then we can update to Laravel 9.

@Julian-Louis
Copy link

Julian-Louis commented Feb 9, 2022

@bishopb Any chance that you might be able to merge this? It's only a composer requirement change and then we can update to Laravel 9.

I just contacted their support to ask them to merge it, I hope they will do it

@jonnott
Copy link
Author

jonnott commented Feb 9, 2022

I just contacted their support to ask them to merge it, I hope they will do it

Hopefully, yes. I recall last major Laravel version, getting Rollbar to pay attention to my PR was a long and tedious process!

@jonnott
Copy link
Author

jonnott commented Feb 9, 2022

I just contacted their support to ask them to merge it, I hope they will do it

Hopefully, yes. I recall last major Laravel version, getting Rollbar to pay attention to my PR was a long and tedious process!

@niektenhoopen @Julian-Louis In the meantime, I have a patched version at https://github.com/jonnott/rollbar-php-laravel/commits/patch-1

@jonnott jonnott mentioned this pull request Feb 9, 2022
@joelbutcher
Copy link

joelbutcher commented Feb 10, 2022

@jonnott You also need to update the CI pipeline files to make sure the tests are covered for Laravel 9 and PHP 8, I'd also recommend updating this file to check support for PHP 8.1. For reference, I've a duplicate PR with these changes here #123

@jonnott
Copy link
Author

jonnott commented Feb 10, 2022

Closing in favour of #123

@jonnott jonnott closed this Feb 10, 2022
@jonnott jonnott deleted the patch-1 branch February 22, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants