Simplify log and fix inconsistency with callback argument #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Notifier.log method by ensuring consistent callback behavior and simplifying the callback normalization logic. The key change addresses an inconsistency where the disabled Rollbar case was not passing null as the second argument to the callback, unlike other error paths in the same method.
Key changes:
- Simplified callback normalization using a ternary operator and arrow function
- Added
nullas second argument when Rollbar is disabled to match the error handling pattern used elsewhere in the method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matux
commented
Nov 10, 2025
|
|
||
| if (!this.options.enabled) { | ||
| return cb(new Error('Rollbar is not enabled')); | ||
| return callback(new Error('Rollbar is not enabled'), null); |
Contributor
Author
There was a problem hiding this comment.
Probably not a big deal since it would be passing undefined, but docstring clearly states a null should be expected.
waltjones
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Ensure
Notifier.logpassesnullas the second argument when Rollbar is disabled to be consistent with contract.Also: Normalize
callbackto a noop when it’s not a function and simplify the callback assignment.Type of change