From 40bc128a8b246a828c36fdef836bc724a8ca4153 Mon Sep 17 00:00:00 2001
From: Tiger Oakes <contact@tigeroakes.com>
Date: Tue, 8 Sep 2020 07:25:29 -0700
Subject: [PATCH] fix(typescript)!: Change `noEmitOnError` default to false
 (#544)

---
 packages/typescript/README.md                  | 18 +++++++++---------
 packages/typescript/src/options/interfaces.ts  |  1 -
 .../test/fixtures/syntax-error/tsconfig.json   |  6 +++++-
 3 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/packages/typescript/README.md b/packages/typescript/README.md
index feb219ce3..412677473 100644
--- a/packages/typescript/README.md
+++ b/packages/typescript/README.md
@@ -13,7 +13,7 @@
 
 ## Requirements
 
-This plugin requires an [LTS](https://github.com/nodejs/Release) Node version (v8.0.0+) and Rollup v1.20.0+. Due to the use of `tslib` to inject helpers, this plugin requires at least [TypeScript 2.1](https://github.com/Microsoft/TypeScript/wiki/Roadmap#21-december-2016). See also [here](https://blog.mariusschulz.com/2016/12/16/typescript-2-1-external-helpers-library#the-importhelpers-flag-and-tslib).
+This plugin requires an [LTS](https://github.com/nodejs/Release) Node version (v8.0.0+) and Rollup v1.20.0+. This plugin also requires at least [TypeScript 3.4](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html).
 
 ## Install
 
@@ -41,9 +41,9 @@ export default {
   input: 'src/index.ts',
   output: {
     dir: 'output',
-    format: 'cjs'
+    format: 'cjs',
   },
-  plugins: [typescript()]
+  plugins: [typescript()],
 };
 ```
 
@@ -95,7 +95,7 @@ Overrides the TypeScript module used for transpilation.
 
 ```js
 typescript({
-  typescript: require('some-fork-of-typescript')
+  typescript: require('some-fork-of-typescript'),
 });
 ```
 
@@ -108,7 +108,7 @@ Overrides the injected TypeScript helpers with a custom version.
 
 ```js
 typescript({
-  tslib: require.resolve('some-fork-of-tslib')
+  tslib: require.resolve('some-fork-of-tslib'),
 });
 ```
 
@@ -119,7 +119,7 @@ Some of Typescript's [CompilerOptions](https://www.typescriptlang.org/docs/handb
 #### `noEmitOnError`
 
 Type: `Boolean`<br>
-Default: `true`
+Default: `false`
 
 If a type error is detected, the Rollup build is aborted when this option is set to true.
 
@@ -151,8 +151,8 @@ export default {
   input: './main.ts',
   plugins: [
     typescript({ module: 'CommonJS' }),
-    commonjs({ extensions: ['.js', '.ts'] }) // the ".ts" extension is required
-  ]
+    commonjs({ extensions: ['.js', '.ts'] }), // the ".ts" extension is required
+  ],
 };
 ```
 
@@ -180,7 +180,7 @@ import typescript from '@rollup/plugin-typescript';
 export default {
   // … other options …
   acornInjectPlugins: [jsx()],
-  plugins: [typescript({ jsx: 'preserve' })]
+  plugins: [typescript({ jsx: 'preserve' })],
 };
 ```
 
diff --git a/packages/typescript/src/options/interfaces.ts b/packages/typescript/src/options/interfaces.ts
index 17733d6fe..9e5fd7740 100644
--- a/packages/typescript/src/options/interfaces.ts
+++ b/packages/typescript/src/options/interfaces.ts
@@ -8,7 +8,6 @@ export type CompilerOptions = import('typescript').CompilerOptions;
 
 export const DEFAULT_COMPILER_OPTIONS: PartialCompilerOptions = {
   module: 'esnext',
-  noEmitOnError: true,
   skipLibCheck: true
 };
 
diff --git a/packages/typescript/test/fixtures/syntax-error/tsconfig.json b/packages/typescript/test/fixtures/syntax-error/tsconfig.json
index 0967ef424..80f7aac1c 100644
--- a/packages/typescript/test/fixtures/syntax-error/tsconfig.json
+++ b/packages/typescript/test/fixtures/syntax-error/tsconfig.json
@@ -1 +1,5 @@
-{}
+{
+  "compilerOptions": {
+    "noEmitOnError": true
+  }
+}