Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): Use this.warn for ts errors #129

Merged
merged 2 commits into from Jan 1, 2020
Merged

Conversation

@NotWoods
Copy link
Member

NotWoods commented Dec 31, 2019

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Moving from console.error to this.warn. Additionally cleaned up the options slightly by isolating mutations and extracting some code to helper functions.

@shellscape shellscape requested review from rollup/plugin-maintainers Dec 31, 2019
@NotWoods NotWoods force-pushed the NotWoods:ts-warn branch from 1954cc3 to e9e13bb Dec 31, 2019
@Kocal
Kocal approved these changes Jan 1, 2020
@shellscape shellscape merged commit 463b5ed into rollup:master Jan 1, 2020
7 checks passed
7 checks passed
10 (Windows)
Details
8 (Windows)
Details
ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v12-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v8-latest Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 3380920...a3562a0
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.