Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): Find tslib asynchronously #131

Merged
merged 2 commits into from Jan 4, 2020

Conversation

@NotWoods
Copy link
Member

NotWoods commented Dec 31, 2019

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Replace the sync methods that find tslib with equivalent async methods.

@shellscape shellscape requested review from pnevares, Kocal, wuweiweiwu and rollup/plugin-maintainers Jan 1, 2020
@Kocal
Kocal approved these changes Jan 1, 2020
@shellscape

This comment has been minimized.

Copy link
Collaborator

shellscape commented Jan 3, 2020

@NotWoods merge conflict popped up

@shellscape shellscape merged commit dbff484 into rollup:master Jan 4, 2020
7 checks passed
7 checks passed
10 (Windows) 10 (Windows)
Details
8 (Windows) 8 (Windows)
Details
ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v12-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v8-latest Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 387e19f...643501e
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.