Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commonjs): resolve export "exports" not found #1363

merged 1 commit into from Dec 15, 2022


Copy link

Rollup Plugin Name: commonjs

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:


Previously, this plugin relied on "synthetic named exports" to get a reference for the module.exports export of a module in a way that would update if module.exports is reassigned.
This apparently caused issues, so this PR changes that to instead use a getter and setter that updates exports if module.exports is reassigned.

Copy link

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge 🎉

Copy link
Member Author

Currently thinking about this, maybe I know a solution that is even more CommonJS spec compliant, let me check. Will convert it to draft for a moment.

@lukastaegert lukastaegert marked this pull request as draft December 5, 2022 16:02
@lukastaegert lukastaegert marked this pull request as ready for review December 15, 2022 04:58
Copy link
Member Author

Turns out my other idea did not really work out. As I already got the go for this, I will merge this one now.

@lukastaegert lukastaegert merged commit 39a39d7 into master Dec 15, 2022
7 checks passed
@lukastaegert lukastaegert deleted the commonjs/exports-not-found branch December 15, 2022 04:59
Copy link

@lukastaegert would you consider merging a patch to replace get/set with Object.defineProperty()? It would help building for some ES3 runtimes, incl. older Rhino builds. Or is it an absolute no go?

Copy link
Member Author

The code in question is theoretically included for every single CommonJS module. Using Object.defineProperty can blow the code up quite a bit and potentially harm tree-shaking for everyone. Can't you run a code transform plugin to rewrite the accessors?

Copy link

Yes, that’s our coping strategy for the time being. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

[@rollup/plugin-commonjs] does not provide an export named 'exports'
3 participants