Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(node-resolve): improve doc related to mainFields #138

Merged
merged 5 commits into from Jan 4, 2020

Conversation

@StreetStrider
Copy link
Contributor

StreetStrider commented Jan 3, 2020

Rollup Plugin Name: rollup-plugin-node-resolve

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

More clear doc related to mainFields priority and distinct options for browser, module, jsnext and main. Rework markup to distinguish values of mainFields and corresponding values in package.json.

More clear doc related to mainFields priority and distinct options for browser, module, jsnext and main. Rework markup to distinguish values of mainFields and corresponding values in package.json.
@shellscape shellscape changed the title node-resolve: improve doc related to mainFields docs(node-resolve): improve doc related to mainFields Jan 3, 2020
@shellscape shellscape requested review from NotWoods, Andarist, Kocal and pnevares Jan 3, 2020
@StreetStrider

This comment has been minimized.

Copy link
Contributor Author

StreetStrider commented Jan 3, 2020

Docs created according to this function.

@shellscape

This comment has been minimized.

Copy link
Collaborator

shellscape commented Jan 3, 2020

Note to reviewers: We can safely ignore the failing Windows tests for now. #137 contains a fix for that.

Simplify valid values

Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com>
@Kocal
Kocal approved these changes Jan 3, 2020
Copy link
Collaborator

shellscape left a comment

Great start, and thanks for opening this PR. A few modifications I'd like to see.

StreetStrider and others added 3 commits Jan 3, 2020
Remove Type/Default info on deprecated properties: jsnext, module and main.
Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com>
Co-Authored-By: Andrew Powell <shellscape@users.noreply.github.com>
@shellscape

This comment has been minimized.

Copy link
Collaborator

shellscape commented Jan 4, 2020

thanks!

@shellscape shellscape merged commit 7b0364f into rollup:master Jan 4, 2020
5 of 7 checks passed
5 of 7 checks passed
10 (Windows) 10 (Windows)
Details
8 (Windows) 8 (Windows)
Details
ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v12-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v8-latest Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ed22851...799b795
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.