Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): Use warning objects for type errors #144

Merged
merged 2 commits into from Jan 7, 2020

Conversation

@NotWoods
Copy link
Member

NotWoods commented Jan 6, 2020

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no (ish)

List any relevant issue numbers:

Description

Changes the warnings and errors so that they include line numbers on the warning object rather than inside the string. This aligns the format of the error messages with Rollup, which is a slight breaking change.

@shellscape shellscape requested review from pnevares and rollup/plugin-maintainers Jan 7, 2020
@Kocal
Kocal approved these changes Jan 7, 2020
@shellscape shellscape merged commit 90919eb into rollup:master Jan 7, 2020
7 checks passed
7 checks passed
10 (Windows)
Details
8 (Windows)
Details
ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v12-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v8-latest Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing eb5340c...c144019
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.