Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript): Use ts.findConfigFile helper #145

merged 4 commits into from Jan 7, 2020


Copy link

NotWoods commented Jan 7, 2020

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:


Typescript has a built in helper for finding the config file that uses the same general algorithm as we do. Let's just rely on Typescript to do the work.

shellscape added 2 commits Jan 7, 2020
@shellscape shellscape requested review from rollup/plugin-maintainers Jan 7, 2020
Kocal approved these changes Jan 7, 2020
@shellscape shellscape merged commit 82abf9a into rollup:master Jan 7, 2020
7 checks passed
7 checks passed
10 (Windows)
8 (Windows)
ci/circleci: analysis Your tests passed on CircleCI!
ci/circleci: node-v10-latest Your tests passed on CircleCI!
ci/circleci: node-v12-latest Your tests passed on CircleCI!
ci/circleci: node-v8-latest Your tests passed on CircleCI!
codecov/patch Coverage not affected when comparing c144019...b841c5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.