Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typeof require === "function" && require #108

Merged
merged 1 commit into from Sep 17, 2016

Conversation

Projects
None yet
1 participant
@Rich-Harris
Copy link
Contributor

commented Sep 17, 2016

Fixes #77 and #83. Rather than rewriting typeof require, this replaces require identifiers (other than those used in require(...) expressions) with a commonjsRequire helper. If it gets called, it'll just throw an error, but in the majority of cases it's not there to get called, it's there for some other runtime check that probably shouldn't be a runtime check.

@Rich-Harris Rich-Harris merged commit 0422ef9 into master Sep 17, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Rich-Harris Rich-Harris deleted the gh-77 branch Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.