Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to exclude node_modules force to strict mode #1244

Closed
yuanyan opened this issue Jan 9, 2017 · 1 comment
Closed

How to exclude node_modules force to strict mode #1244

yuanyan opened this issue Jan 9, 2017 · 1 comment
Labels
x¹ ⋅ abandoned

Comments

@yuanyan
Copy link

yuanyan commented Jan 9, 2017

No description provided.

@Rich-Harris
Copy link
Contributor

Afraid it's not possible. ES modules are always strict mode, meaning that things like with and octal literals with a leading 0 won't even parse (because Acorn is running with sourceType: 'module'), much less execute.

The long and the short of it is that it's 2017 — if your dependencies depend on non-strict behaviour, it's time to replace them.

simonbuchan added a commit to simonbuchan/rollup that referenced this issue Aug 19, 2022
@simonbuchan
Add test for rollup#1244
b5ce279
@simonbuchan simonbuchan mentioned this issue Aug 19, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
x¹ ⋅ abandoned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take first resolve id attributes simonbuchan/rollup
3 participants
@yuanyan @Rich-Harris @fregante