Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum required Node version to Node 10 #3320

Open
shellscape opened this issue Jan 5, 2020 · 5 comments
Open

Update minimum required Node version to Node 10 #3320

shellscape opened this issue Jan 5, 2020 · 5 comments

Comments

@shellscape
Copy link
Contributor

@shellscape shellscape commented Jan 5, 2020

Expected Behavior / Situation

Not applicable

Actual Behavior / Situation

Node 8 has exited LTS and is now end-of-life. https://nodejs.org/en/about/releases/

Modification Proposal

I propose that Rollup remove official support for Node 8. This would involve:

  • An announcement
  • Updating documentation
  • Updating plugins (and their documentation)
  • Updating engines in package.json
  • Updating CI configurations
  • Bumping a major version

Please share thoughts and reactions. Please use the 👍 reaction button (top right of this post) to show support for this. Please comment and/or use other reactions to show support against this proposal.

@lukastaegert lukastaegert changed the title Node 8 is End-of-Life Update minimum required Node version to Node 10 Jan 6, 2020
@lukastaegert lukastaegert added this to To do in Release 2.0.0 via automation Jan 6, 2020
@lukastaegert

This comment has been minimized.

Copy link
Member

@lukastaegert lukastaegert commented Jan 6, 2020

We definitely want this. However I think it would be waste of a major version to do this separate from the other pending breaking changes so I updated the Rollup 2.0.0 project and added it: https://github.com/rollup/rollup/projects/2

I also adjusted the title so that it looks better in the Project view.

I think once the current batch of PRs is reviewed and hopefully released, I would be free to tackle some of the 2.0.0 projects. My suggestion would be to create PRs for the 2.0.0 release against a separate 2.0.0 branch that we merge to master once all breaking changes have been collected. We could also do preview releases (i.e. 2.0.0-0, 2.0.0-1) for each PR merged to the 2.0.0 branch as long as we do not move the "latest" tag.

@shellscape

This comment has been minimized.

Copy link
Contributor Author

@shellscape shellscape commented Jan 6, 2020

The nice thing about major versions is that there are a lot of numbers 😄 I tend to lean more towards keeping everything current than relying on scheduling or task lists when it comes to Node versions - especially so when end of life is reached on a version. Life comes at us fast, and there's no telling how long it'll take to get through that batch.

Waiting to update will also hold up the plugins repo and the 22 core plugins.

@lukastaegert

This comment has been minimized.

Copy link
Member

@lukastaegert lukastaegert commented Jan 6, 2020

Every major version causes unnecessary friction for users, but that’s just my opinion. It is not that updating minimum requirements will enable us to do anything fantastic that could not wait for a few weeks. The code is already using async await. I wonder why this is blocking the plugins, though. There is no reason to have a hard dependency here.

@shellscape

This comment has been minimized.

Copy link
Contributor Author

@shellscape shellscape commented Jan 6, 2020

I would agree that it does cause friction for some users. That can be mitigated by good communication, which I think we definitely have.

We adopted a policy for the plugins that we follow rollup core as the source of truth for engines. It makes sense - if rollup core supported Node 8 but a plugin didn't, that'd be kind of silly. Wouldn't want to hamstring users of Node 8 while core still supported it.

I'd also agree that a few weeks is no big deal.

@lukastaegert

This comment has been minimized.

Copy link
Member

@lukastaegert lukastaegert commented Jan 6, 2020

I'll see it gets high priority now.

@lukastaegert lukastaegert moved this from To do to In progress in Release 2.0.0 Jan 19, 2020
@lukastaegert lukastaegert moved this from In progress to Ready for merge in Release 2.0.0 Jan 19, 2020
@lukastaegert lukastaegert moved this from Ready for merge to Done in Release 2.0.0 Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 2.0.0
  
Done
2 participants
You can’t perform that action at this time.