Symlink support #447

Closed
naorye opened this Issue Jan 13, 2016 · 6 comments

Projects

None yet

7 participants

@naorye
naorye commented Jan 13, 2016

Importing from symlink doesn't work. For example:

import func from 'common/script/func';

func();

Where 'common' is a symlink in 'node_modules'.
The resulting file is the sameas the original.

@Rich-Harris Rich-Harris added the bug label Jan 19, 2016
@mmolhoek

would love to see this one fixed/merged, so ionic 2 will read npm linked modules correctly

@pascalrijk

+1

@scottopolis

I'm having this issue as well.

@patriknyblad

+1

@Rich-Harris Rich-Harris added a commit that referenced this issue Dec 20, 2016
@Rich-Harris Rich-Harris merge master -> gh-447 2d7f8a7
@Rich-Harris
Contributor

Finally fixed in 0.37.1

@yaycmyk
yaycmyk commented Jan 9, 2017 edited

@Rich-Harris Would it be possible to deduplicate followed symlinks?

I'm using a lerna monorepo and consume the same module in many other packages (it gets symlinked into their node_modules), but once the symlink has been followed, it isn't identified as already being in the corpus of imported modules and thus is included many times in the master bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment