Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #2024

Merged
merged 2 commits into from Mar 5, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -15,9 +15,11 @@ const commitHash = (function () {
}
})();

const now = new Date(process.env.SOURCE_DATE_EPOCH ? (process.env.SOURCE_DATE_EPOCH * 1000) : new Date().getTime()).getTime();

This comment has been minimized.

Copy link
@lukastaegert

lukastaegert Mar 2, 2018

Member

The previous version would put a human readable date into the banner. Would it be ok with your efforts to remove the final getTime() here? Or maybe use toISOString instead to get a more standardised output?

This comment has been minimized.

Copy link
@lamby

lamby Mar 2, 2018

Author Contributor

I'm easy! :) (indeed, see the linked Debian bug for a patch for the previous version)

This comment has been minimized.

Copy link
@lukastaegert

lukastaegert Mar 2, 2018

Member

Ah, I see! I guess I would go with the original suggestion then.


const banner = `/*
Rollup.js v${pkg.version}
${new Date()} - commit ${commitHash}
${now} - commit ${commitHash}
https://github.com/rollup/rollup
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.