Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use browser relative path algorithm for chunks #2902

Merged
merged 1 commit into from Jun 6, 2019

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jun 6, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2901

Description

This will fix an issue where a relative external dependency of a chunk was outside dir in a way that was no longer covered by the current working directory. We do this by using and adjusting our browser polyfill for path.relative for chunks.

@lukastaegert lukastaegert merged commit 7179390 into master Jun 6, 2019
6 checks passed
6 checks passed
ci/circleci: analysis Your tests passed on CircleCI!
Details
ci/circleci: node-v10-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v6-latest Your tests passed on CircleCI!
Details
ci/circleci: node-v8-latest Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@lukastaegert lukastaegert deleted the gh-2901-relative-external branch Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant