Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only overwrite content when resolving import.meta properties #2986

Merged
merged 1 commit into from Jul 9, 2019

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jul 8, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

A small issue I stumbled across when working on #2938. As import meta properties are resolved AFTER everything else is rendered it is possible due to some quirks of magic-string that content is removed that should not be removed. For instance this code:

export const url = import.meta.url;

would become in SystemJS

System.register('bundle', [], function (exports, module) {
	'use strict';
	return {
		execute: function () {

			const url = exports('url', 'url'

		}
	};
});

Notice the missing closing bracket. This issue fixes this by making import.meta properties a "contentOnly" update, which should prevent other issues as well.

@lukastaegert lukastaegert force-pushed the fix-import-meta-resolution branch from a52c2df to c92cdcd Compare Jul 8, 2019
@lukastaegert lukastaegert merged commit 893c725 into master Jul 9, 2019
7 checks passed
@lukastaegert lukastaegert deleted the fix-import-meta-resolution branch Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant